Closed rbuj closed 4 years ago
@raveit65 The merge conflict has been fixed.
See https://travis-ci.org/mate-desktop/mate-power-manager/jobs/654791846#L2941
We have some -Wunused-variable
warnings.
brightness-applet.c: In function 'gpm_applet_dialog_about_cb':
brightness-applet.c:806:14: warning: unused variable 'translator_credits' [-Wunused-variable]
806 | const char *translator_credits = NULL;
| ^~~~~~~~~~~~~~~~~~
brightness-applet.c:777:40: warning: unused parameter 'action' [-Wunused-parameter]
777 | gpm_applet_dialog_about_cb (GtkAction *action, gpointer data)
| ~~~~~~~~~~~^~~~~~
brightness-applet.c:777:57: warning: unused parameter 'data' [-Wunused-parameter]
777 | gpm_applet_dialog_about_cb (GtkAction *action, gpointer data)
| ~~~~~~~~~^~~~
unused variable 'translator_credits'
is definitely a new warning compare to previous build.
https://travis-ci.org/mate-desktop/mate-power-manager/jobs/654632947#L2938
@raveit65 The warning: "unused variable 'translator_credits'" has been removed.
The warning: "unused variable 'translator_credits'" has been removed.
This shows how useful it is to use -Wunused-variable
for travis builds ;)
But i think we should use -Wno-unused-variable
in general for local or distro builds.
See https://github.com/mate-desktop/mate-panel/pull/1050#issuecomment-576718035.
I will do a PR for mate-common.
And we can add -Wunused-variable
to travis config for every repo.
I will consider missing translators in dialog as bug fix and cherry-pick it to 1.24 branch.
@rbuj We have a merge conflict.