search

mate-desktop / mate-power-manager

Power management tool for the MATE desktop
https://mate-desktop.org
GNU General Public License v2.0
59 stars 51 forks source link

Use gtk_show_about_dialog to show about dialog #325

Closed rbuj closed 4 years ago

raveit65 commented 4 years ago

@rbuj We have a merge conflict.

rbuj commented 4 years ago

@raveit65 The merge conflict has been fixed.

raveit65 commented 4 years ago

See https://travis-ci.org/mate-desktop/mate-power-manager/jobs/654791846#L2941 We have some -Wunused-variable warnings.

brightness-applet.c: In function 'gpm_applet_dialog_about_cb':

brightness-applet.c:806:14: warning: unused variable 'translator_credits' [-Wunused-variable]

  806 |  const char *translator_credits = NULL;

      |              ^~~~~~~~~~~~~~~~~~

brightness-applet.c:777:40: warning: unused parameter 'action' [-Wunused-parameter]

  777 | gpm_applet_dialog_about_cb (GtkAction *action, gpointer data)

      |                             ~~~~~~~~~~~^~~~~~

brightness-applet.c:777:57: warning: unused parameter 'data' [-Wunused-parameter]

  777 | gpm_applet_dialog_about_cb (GtkAction *action, gpointer data)

      |                                                ~~~~~~~~~^~~~

unused variable 'translator_credits' is definitely a new warning compare to previous build. https://travis-ci.org/mate-desktop/mate-power-manager/jobs/654632947#L2938

rbuj commented 4 years ago

@raveit65 The warning: "unused variable 'translator_credits'" has been removed.

raveit65 commented 4 years ago

The warning: "unused variable 'translator_credits'" has been removed.

This shows how useful it is to use -Wunused-variable for travis builds ;) But i think we should use -Wno-unused-variable in general for local or distro builds. See https://github.com/mate-desktop/mate-panel/pull/1050#issuecomment-576718035. I will do a PR for mate-common. And we can add -Wunused-variable to travis config for every repo.

raveit65 commented 4 years ago

I will consider missing translators in dialog as bug fix and cherry-pick it to 1.24 branch.