search

mate-desktop / mate-power-manager

Power management tool for the MATE desktop
https://mate-desktop.org
GNU General Public License v2.0
59 stars 51 forks source link

Add support for gaming inputs #374

Closed Zenkibou closed 2 years ago

Zenkibou commented 2 years ago

Add support for gaming inputs as well as their icons. In addition, display the device name even if the vendor is empty. I tested this with my DualShock 3 connected over bluetooth.

Here is how it looks with this change: Screenshot at 2022-02-17 09-31-23 Screenshot at 2022-02-17 09-34-46

And how it looks without the change: Screenshot at 2022-02-17 09-37-23 Screenshot at 2022-02-17 09-39-49

Zenkibou commented 2 years ago

It looks good to me, but you don't need to update the translations (mate-power-manager.pot and po/*.po files) since it's performed in several stages.

Sorry, I didn't see those change when I committed. I can update my pull request without those changes if it's better.

Zenkibou commented 2 years ago

See my gaming-input branch without the po changes.

raveit65 commented 2 years ago

See my gaming-input branch without the po changes.

Looks good, but this needs to be revert here before merging. Your master branch is used here.

lukefromdc commented 2 years ago

Cannot test this, I don't have the hardware

Zenkibou commented 2 years ago

I wasn't able to change master without closing this pull request, so see the clean pull request #376 without the .po changes.