search

mate-desktop / mate-power-manager

Power management tool for the MATE desktop
https://mate-desktop.org
GNU General Public License v2.0
59 stars 51 forks source link

Make the status icon more a11y friendly #375

Open tyrylu opened 2 years ago

tyrylu commented 2 years ago

This allows assistive technologies to see the tooltip of the status icon, which makes it much more useful.

raveit65 commented 2 years ago 
[rave@mother mate-power-manager]$ LANG=C
[rave@mother mate-power-manager]$ git pull https://github.com/tyrylu/mate-power-manager.git trayicon_a11y
From https://github.com/tyrylu/mate-power-manager
 * branch            trayicon_a11y -> FETCH_HEAD
fatal: Not possible to fast-forward, aborting.
[rave@mother mate-power-manager]$
raveit65 commented 2 years ago

I don't see any title in the tooltip with PR. It simply looks like before.

tyrylu commented 2 years ago

Try using Orca for your test, this PR introduces no visual changes.

raveit65 commented 2 years ago

Sorry, i am not familiar with orca. Pushing that to another reviewer.

zhuyaliang commented 2 years ago

gtk_status_icon_set_title has been deprecated since version 3.14 and should not be used in newly-written code.

tyrylu commented 2 years ago

That's true, however the power manager uses the status icon APIs, so this PR adds accessibility without rewriting the entire status icon handling code which might be somewhere on the roadmap or it might not, I don't know and i have no idea how Mate handles the new notifications either.

lukefromdc commented 2 years ago

Note that ALL status icon code is deprecated in GTK as it depends on GtkPlug/GtkSocket which in turn depend on Xembed, which in turn depends on Xorg and is not available in Wayland.

Therefore, there is no reason given that one is working on a status icon to worry about any particular piece of code being deprecated. We just need to make it work, and GNOME does not remove deprecated symbols within the same major version (Such as GTK 3.anything). As long as we use Gtk3 and do not transition to Gtk4 all of that is still supposed to work. To bitrot this and break it would probably require some big change in cairo or xorg itself. and so far GTK 2 still works and has not become broken.

On 4/25/2022 at 9:32 AM, "Lukáš Tyrychtr" @.***> wrote:

That's true, however the power manager uses the status icon APIs, so this PR adds accessibility without rewriting the entire status icon handling code which might be somewhere on the roadmap or it might not, I don't know and i have no idea how Mate handles the new notifications either.

-- Reply to this email directly or view it on GitHub: https://github.com/mate-desktop/mate-power- manager/pull/375#issuecomment-1108579885 You are receiving this because you are subscribed to this thread.

Message ID: <mate-desktop/mate-power- @.***>

lukefromdc commented 1 year ago

Any updates on this?

tyrylu commented 1 year ago

I'd like to know myself...