search

mate-desktop / mate-power-manager

Power management tool for the MATE desktop
https://mate-desktop.org
GNU General Public License v2.0
59 stars 51 forks source link

Statistics uses gpm- prefixed icons, not Upower #377

Closed newhoa closed 2 years ago

newhoa commented 2 years ago

There seems to be an inconsistency between the mate-power-manager panel tray/indicator icons and the mate-power-statistics icons.

It seems mpm switched to using the standard Upower names for the tray/indicator icons, but the icons in the power statistics window still uses the old gpm- icons.

It would be really nice to move away from the gpm- naming in favor of more standard naming. Gnome, Cinnamon, Budgie, and Xfce have done so and many icon themes don't provide the gpm- icons (including the MATE icon theme and the Yaru-MATE theme).

newhoa commented 2 years ago

It looks like the menu of the tray icon also uses gpm- icons for devices instead of standards like input-keyboard and input-mouse (or just the battery icon which would probably be more legible).

Aside from being non-standard names, it's also fairly difficult to see. It's very difficult to fit a keyboard and battery symbol into 16px. Especially with increasing monitor resolutions and higher DPI displays these become very difficult to read.

It might be better to just use the battery icon to show the charge level and have the text say the device. Or show just the device icon and have the charge level in the text.

newhoa commented 2 years ago

Ok, this is slightly more confusing to me. The tray icon prefers a few non-symbolic and gpm- icons over symbolic icons. Which means you can't have symbolic icons in the tray, and regular icons in the statistics (and most themes don't provide 48px symbolic icons).

I think it would be best if they both preferred the standard naming, and if the tray icon requires symbolic it could request the upower name with -symbolic on the end. Here is a list of the standard names:

ac-adapter
battery-caution
battery-caution-charging
battery-empty
battery-empty-charging
battery-full
battery-full-charged
battery-full-charging
battery-good
battery-good-charging
battery-low
battery-low-charging
battery-missing

Just for reference, this is the order in which mate-power-manager tray and power stats prefer what names (using battery-caution-charging, an almost empty charging battery, as an example).

Tray

battery-000-charging
gpm-battery-000-charging
battery-caution-charging-symbolic
battery-caution-charging
battery-000
gpm-battery-000
battery-caution-symbolic
battery-caution
battery-000-charging-symbolic
gpm-battery-000-charging-symbolic
battery-000-symbolic
gpm-battery-000-symbolic

Power Statistics

gpm-battery-000-charging
gpm-battery-000
gpm-battery-000-charging-symbolic
gpm-battery-000-symbolic
newhoa commented 2 years ago

Closing this one and going to resubmit it with hopefully clearer and more up to date info. Edit: See #378