mate-desktop / mate-power-manager

Power management tool for the MATE desktop
https://mate-desktop.org
GNU General Public License v2.0
59 stars 51 forks source link

1.27.0: not ready for gettext 0.22 #390

Open kloczek opened 12 months ago

kloczek commented 12 months ago
rm -f hu.gmo && /usr/bin/msgmerge --for-msgfmt -o hu.1po hu.po mate-power-manager.pot && /usr/bin/msgfmt -c --statistics --verbose -o hu.gmo hu.1po && rm -f hu.1po
hu.1po:980: 'msgstr' is not a valid C format string, unlike 'msgid'. Reason: In the directive number 2, the argument size specifier is invalid.
/usr/bin/msgfmt: found 1 fatal error
hu.1po: 380 translated messages.
raveit65 commented 12 months ago

https://app.transifex.com/mate/MATE/dashboard/

kloczek commented 12 months ago

Hmm 🤔 .. that link has nothing to do with reported issue.

kloczek commented 10 months ago

gentle ping .. 🤔

raveit65 commented 10 months ago

This is an translation error caused by translators at transifex. For that reason i gave you the link to transifex. This have to be fixed there.

kloczek commented 10 months ago

On that link are only statistics of the translations.

raveit65 commented 10 months ago

You need a account, become a member of your language team and translate. Sorry i can't help you more.

kloczek commented 10 months ago

Why I need such help? Broken file is in this git repo. If fix is already present at transifex why this cannot be commited? 🤔

raveit65 commented 10 months ago

Is the fix already present at transifex? Why do you think that? Btw. we don't have this issue in CI.

kloczek commented 10 months ago

You pointed on transifex as place where I can find solution. I'm not thinking about anything.

kloczek commented 10 months ago

Btw. we don't have this issue in CI.

Again .. I;'m using gettext 0.22.

raveit65 commented 10 months ago

You pointed on transifex as place where I can find solution.

No, you should become a translator of your language and fix it for yourself. I can't do that for you because I don't speak Hungary language

kloczek commented 10 months ago

This about HUNGARIAN translation. I'm Polish and I'm not translator. Fact is that there is no fixes in git repo.

paravoid commented 1 week ago

This is breaking the build on recent Debian systems, see https://bugs.debian.org/1074753. In fact, it has resulted in mate-power-manager being removed from testing/trixie.

I'm not a Hungarian speaker either, but the issue is with the format specifier, not the text: replacing %.0lf%% with %.0f%% (like the original English text, and every other translation) fixes this.

lukefromdc commented 1 week ago

Than we probably need to remove the broken translation from the build. This needs the attention of one of the team members that knows more about the translation system than I do. We are getting problems with NEW translations that are broken in all packages now, which means the translations cannot be updated and any releases must use the old translations. If they cannot be fixed they need to be moved to a branch and removed from master. This problem should be considered an emergency as it has the potential to kill MATE as a DE offered by distros, or even make it useless in all languages but English if Native Language Support becomes broken.

paravoid commented 4 days ago

I understand that there is probably a wider translation maintainership issue to consider here. I'm not too familiar with the translation issues you're mentioning but I trust that you know best :)

That said, I wouldn't let perfect be the enemy of good here: we're talking about an obvious single character patch that would immediately fix this build failure. I'd commit that, and then perhaps continue discussing how to handle broken translations?

lukefromdc commented 4 days ago

Translations are done at Transifex not here, any corrections need to be done on that end. I myself do not know how to fix this, until someone does fix it I cannot include any translation updates in any new release