mate-desktop / mate-screensaver

MATE screen saver and locker
https://mate-desktop.org
GNU General Public License v2.0
48 stars 40 forks source link

Fix: idle slider display bug #138

Closed sc0w closed 7 years ago

sc0w commented 7 years ago

Fixes #101

raveit65 commented 7 years ago

This works well if time is under 1 hour and exactly 2 hours, but not for 1 hour to 2hours. screensaver-ui-1 screensaver-ui-2 screensaver-ui-3

sc0w commented 7 years ago

it works fine here with LANG C

I think because "hour" and "stunde" have different length

I will investigate to work with all langs

raveit65 commented 7 years ago

Indeed, it works well with english :-)

monsta commented 7 years ago

I don't think it's possible to make this work in all locales...

sc0w commented 7 years ago

@raveit65 @monsta please test

commit rebased, now it works fine here with the languages C, ES, LT, RU, DE, and I think it must work with all

raveit65 commented 7 years ago

Fine with german ,french, vi_VN, uk_UA, pt_BR, pl_PL and zh_CN. But minutes > 9 are broken with fi_FI

sc0w commented 7 years ago

@raveit65 please test again

with latest changes, it works here with:

id_ID, pt_BR, hy_AM, is_IS, it_IT, ja_JP, sr_RS, ko_KR, sl_SI, sk_SK, lt_LT, bg_BG, ru_RU, ms_MY

monsta commented 7 years ago
monsta@asylum:~/mate/mate-screensaver$ ls -l po/*.po | wc -l
93

That's a long way 😄

sc0w commented 7 years ago

@monsta no problem, I will test all :)

sc0w commented 7 years ago

tested and working:

  am_ET.UTF-8... done
  ar_SA.UTF-8... done
  as_IN.UTF-8... done
  ast_ES.UTF-8... done
  be_BY.UTF-8... done
  bg_BG.UTF-8... done
  bn_BD.UTF-8... done
  bn_IN.UTF-8... done
  br_FR.UTF-8... done
  bs_BA.UTF-8... done
  ca_ES.UTF-8... done
  ca_ES.UTF-8@valencia... done
  cmn_TW.UTF-8... done
  crh_UA.UTF-8... done
raveit65 commented 7 years ago

fi_FI is fine now, thx for hard testing....

raveit65 commented 7 years ago

merged https://github.com/mate-desktop/mate-screensaver/commit/52df89dc6ce7c3c58dcac6b781b8ff540336fce8 thx.

sc0w commented 7 years ago

@raveit65

too fast, cy_GB doesn't work, I am testing to work in all

I will open new PR when I finish :)

sc0w commented 7 years ago

The fix to all languages: https://github.com/mate-desktop/mate-screensaver/pull/139