Closed sunweaver closed 5 years ago
As a side note, this new --unlock
option may become interesting to X2Go or other remote technologies that support resuming a session. Two possible use cases:
This works fine. I just tested the command via ssh connection to unlock a session in VM. But can we have a short command option (-u) too, please?
[rave@f28 ~]$ mate-screensaver-command --help
<cut>
Application Options:
--exit Causes the screensaver to exit gracefully
-q, --query Query the state of the screensaver
-t, --time Query the length of time the screensaver has been active
-l, --lock Tells the running screensaver process to lock the screen immediately
--unlock Tells the running screensaver process to unlock the screen immediately
-c, --cycle If the screensaver is active then switch to another graphics demo
-a, --activate Turn the screensaver on (blank the screen)
-d, --deactivate If the screensaver is active then deactivate it (un-blank the screen)
-p, --poke Poke the running screensaver to simulate user activity
-i, --inhibit Inhibit the screensaver from activating. Command blocks while inhibit is active.
-n, --application-name The calling application that is inhibiting the screensaver
-r, --reason The reason for inhibiting the screensaver
-V, --version Version of this application
Hi,
On Mo 21 Jan 2019 17:11:10 CET, raveit65 wrote:
This works fine. I just tested the command via ssh connection to
unlock a session in VM. But can we have a short command option (-u) too, please?[rave@f28 ~]$ mate-screensaver-command --help <cut> Application Options: --exit Causes the screensaver to exit gracefully -q, --query Query the state of the screensaver -t, --time Query the length of time the screensaver has been active -l, --lock Tells the running screensaver process to lock the screen immediately --unlock Tells the running screensaver process to unlock the screen immediately -c, --cycle If the screensaver is active then switch to another graphics demo -a, --activate Turn the screensaver on (blank the screen) -d, --deactivate If the screensaver is active then deactivate it (un-blank the screen) -p, --poke Poke the running screensaver to simulate user activity -i, --inhibit Inhibit the screensaver from activating. Command blocks while inhibit is active. -n, --application-name The calling application that is inhibiting the screensaver -r, --reason The reason for inhibiting the screensaver -V, --version Version of this application
I just pushed an updated commit to the PR branch.
In fact, you found two flaws. I still had "-l" for unlock and that was
also in the man page. I fixed both places now. The new additional
short option now is "-u".
Mike --
DAS-NETZWERKTEAM mike gabriel, herweg 7, 24357 fleckeby mobile: +49 (1520) 1976 148 landline: +49 (4354) 8390 139
GnuPG Fingerprint: 9BFB AEE8 6C0A A5FF BF22 0782 9AF4 6B30 2577 1B31 mail: mike.gabriel@das-netzwerkteam.de, http://das-netzwerkteam.de
As this is a simple PR i will merge this without a second review.
…r via CLI.
As the use can unlock the session via cmdline anyway already (e.g. killall mate-screensaver, or via systemd), I'd like to propose providing the user with a generic way to unlock the screensaver via the
mate-screensaver-command
tool. This PR introduces the--unlock
option.