search

mate-desktop / mate-screensaver

MATE screen saver and locker
https://mate-desktop.org
GNU General Public License v2.0
48 stars 40 forks source link

Set debug & warning flags using new mate-common macros #208

Closed rbuj closed 4 years ago

raveit65 commented 4 years ago

LGTM,

[rave@mother mate-screensaver-dist]$ ./autogen.sh 

        cflags:                   
        Warning flags:            -Wall -Wmissing-prototypes

[rave@mother mate-screensaver-dist]$ ./configure --enable-compile-warnings=no

        cflags:                   
        Warning flags:            

[rave@mother mate-screensaver-dist]$ ./configure --enable-compile-warnings=yes

        cflags:                   
        Warning flags:            -Wall -Wmissing-prototypes

[rave@mother mate-screensaver-dist]$ ./configure --enable-compile-warnings=maximum

        cflags:                   
        Warning flags:            -Wall -Wmissing-prototypes -Wbad-function-cast -Wcast-align -Wextra -Wformat-nonliteral -Wmissing-declarations -Wmissing-field-initializers -Wnested-externs -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-prototypes -Wno-sign-compare

[rave@mother mate-screensaver-dist]$ ./configure --enable-compile-warnings=error

        cflags:                   
        Warning flags:            -Wall -Wmissing-prototypes -Wbad-function-cast -Wcast-align -Wextra -Wformat-nonliteral -Wmissing-declarations -Wmissing-field-initializers -Wnested-externs -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-prototypes -Wno-sign-compare -Werror

[rave@mother mate-screensaver-dist]$ ./configure --enable-debug=yes

        cflags:                    -g -O0
        Warning flags:            -Wall -Wmissing-prototypes

[rave@mother mate-screensaver-dist]$ ./configure --enable-debug=info

        cflags:                    -g
        Warning flags:            -Wall -Wmissing-prototypes

[rave@mother mate-screensaver-dist]$ ./configure --enable-debug=profile

        cflags:                    -g -pg
        Warning flags:            -Wall -Wmissing-prototypes

[rave@mother mate-screensaver-dist]$ ./configure --enable-debug=no

        cflags:                   
        Warning flags:            -Wall -Wmissing-prototypes

[rave@mother mate-screensaver-dist]$

@rbuj I don't think we need the maintainer mode now, or?

Maintainer mode:          yes
rbuj commented 4 years ago

@raveit65 We can keep AM_MAINTAINER_MODE, this macro is related to rebuild rules, such as checking file timestamps.

raveit65 commented 4 years ago

Ok, than it is fine. I recall that we removed the mode in another repo.

rbuj commented 4 years ago

@raveit65 We removed MAINTAINER_CFLAGS, https://github.com/mate-desktop/mate-utils/commit/58f44578baf5fc6419b1a68be3d3f0ae7ca54e3e