search

mate-desktop / mate-screensaver

MATE screen saver and locker
https://mate-desktop.org
GNU General Public License v2.0
48 stars 40 forks source link

Fix invalid gnome-logo-white.svg #226

Closed lah7 closed 4 years ago

lah7 commented 4 years ago

This fixes an issue where the "Floating GNOME" screensaver in MATE 1.24 is blank as the SVG itself cannot be loaded. It wasn't possible to load the SVG in viewers or editors either.

The Floating GNOME screensaver is now operational after this change.

esteelpaz commented 4 years ago

This issue affects my various MATE distros, so thanks to @lah7 for filing this . . . the GNOME Floating Feet screensaver is sorely missed. Appreciate the fix on it . . . .

lukefromdc commented 4 years ago

For some reason the floating foot logo still works with my somewhat old mate-screensaver locally built 1.24.0+git20200312-1luke1_amd64.deb package and presumably also with the package I built from the 1.24.0 release

(note that I've only had a limited ability to contribute for the past two months as I was away with limited access to AC power to run the desktop at some times and at others limited access to the Internet. I am now back unless things go bad in the Washington DC area yet again).

lah7 commented 4 years ago

I would guess whichever library parsing the SVG "just worked" for some versions/distros all these years. The original SVG comes up as invalid (the xmlns in particular) when thrown into the W3C validator. GitHub, Inkscape and Eye of MATE were unable to render the file.

Over here, it's working again under Ubuntu MATE 20.04, where the bug was spotted.