mate-desktop / mate-screensaver

MATE screen saver and locker
https://mate-desktop.org
GNU General Public License v2.0
48 stars 40 forks source link

gentoo thinks you're using pam wrong? (wrong password causes wrong error string) #237

Closed bunder2015 closed 3 years ago

bunder2015 commented 3 years ago

Expected behaviour

"Incorrect password" when typing the wrong password

Actual behaviour

"Not permitted to gain access at this time"

Steps to reproduce the behaviour

MATE general version

1.24.1

Package version

1.24.1

Linux Distribution

gentoo

Link to downstream report of your Distribution

https://bugs.gentoo.org/752060 https://bugs.gentoo.org/752390

I don't know how else to convince them that they messed something up, sorry for the issue spam.

lukefromdc commented 3 years ago

Any chance this is a more general issue with PAM 1.4.0 or with how mate-screensaver interacts with it? With Debian Unstable we have PAM 1.3.1 and this makes me wonder if that's for a reason.

Also note that in Debian we have to keep /etc/pam.d/mate-screensaver entirely OUT of the installed package or the dialog either won't appear or won't work(I forgot which one).

bunder2015 commented 3 years ago

I wish I had a better answer, but I believe the existing pam.d file is fine as it was working under previous versions off pam. To my knowledge the biggest change was changing tally for faillock. I tried debugging it but sadly I'm not a pam expert... and the gentoo maintainers won't give me a decent explanation as to why its not pam's problem.

The pam.d file references system-auth for the most part, here's a copy of the old one and new one, they both seem somewhat reasonable to me... https://gist.github.com/bunder2015/ba391801c3fae4c531e348e82aa9a16e