search

mate-desktop / mate-screensaver

MATE screen saver and locker
https://mate-desktop.org
GNU General Public License v2.0
48 stars 40 forks source link

Corrected several icon translations (which broke the .desktop icons) #245

Closed sebastianschauenburg closed 3 years ago

sebastianschauenburg commented 3 years ago

This string should not be translated at all (and it's not available on Transifex for translation, I checked). Similar fix as https://github.com/mate-desktop/mate-screensaver/pull/240

rbuj commented 3 years ago

See #242

sebastianschauenburg commented 3 years ago

Added fixes for several other languages as well.

sebastianschauenburg commented 3 years ago

if there is any doubt about these changes, please read my recent blogpost about this specific enhancement

sebastianschauenburg commented 3 years ago

@rbuj seems like #242 is OK and has been merged. Could you do the same with this request please? :-)

rbuj commented 3 years ago

l10n: The translations are managed at https://www.transifex.com/mate/MATE/dashboard/. We have already fixed this kind of issue on other MATE components, as we don't fetch the translation for the icon name.

sebastianschauenburg commented 3 years ago

@rbuj I checked the strings at Transifex and they were not present there anymore, currently. But in this repository, the .po files still contain the translated (or copied) strings, which seem incorrect? I'm fine with not accepting this pull request, but it would mean #242 should've also not been accepted, for consistency :wink: Just tried to help out here.

rbuj commented 3 years ago

Even if the icon names are in the catalog they are not used for generating the desktop files.