search

mate-desktop / mate-screensaver

MATE screen saver and locker
https://mate-desktop.org
GNU General Public License v2.0
48 stars 40 forks source link

Sign conversion bool to guint #270

Closed rbuj closed 2 years ago

rbuj commented 2 years ago 
gs-listener-dbus.c:366:31: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
                listener->priv->throttled = throttled;
                                          ~ ^~~~~~~~~
gs-listener-dbus.c:393:33: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
        listener->priv->session_idle = idle;
                                     ~ ^~~~
gs-listener-dbus.c:411:27: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
        listener->priv->active = active;
                               ~ ^~~~~~
gs-listener-dbus.c:499:33: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
        listener->priv->session_idle = idle;
                                     ~ ^~~~
gs-listener-dbus.c:544:40: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
                listener->priv->activation_enabled = enabled;
                                                   ~ ^~~~~~~
--
gs-watcher-x11.c:206:33: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
                        watcher->priv->idle_notice = in_effect;
                                                   ~ ^~~~~~~~~
gs-watcher-x11.c:233:26: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
                        watcher->priv->idle = is_idle;
                                            ~ ^~~~~~~
gs-watcher-x11.c:272:27: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
                watcher->priv->active = active;
                                      ~ ^~~~~~
gs-watcher-x11.c:312:28: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
                watcher->priv->enabled = enabled;
                                       ~ ^~~~~~~
--
gs-manager.c:421:30: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
                manager->priv->throttled = throttled;
                                         ~ ^~~~~~~~~
gs-manager.c:465:32: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
                manager->priv->lock_active = lock_active;
                                           ~ ^~~~~~~~~~~
gs-manager.c:498:33: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
                manager->priv->lock_enabled = lock_enabled;
                                            ~ ^~~~~~~~~~~~
gs-manager.c:512:35: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
                manager->priv->logout_enabled = logout_enabled;
                                              ~ ^~~~~~~~~~~~~~
gs-manager.c:530:37: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
                manager->priv->keyboard_enabled = enabled;
                                                ~ ^~~~~~~
gs-manager.c:548:40: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
                manager->priv->user_switch_enabled = user_switch_enabled;
                                                   ~ ^~~~~~~~~~~~~~~~~~~
--
gs-window-x11.c:1538:28: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
        window->priv->dialog_up = dialog_up;
                                ~ ^~~~~~~~~
--
gs-window-x11.c:1822:31: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
        window->priv->lock_enabled = lock_enabled;
                                   ~ ^~~~~~~~~~~~
gs-window-x11.c:1840:35: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
        window->priv->keyboard_enabled = enabled;
                                       ~ ^~~~~~~
gs-window-x11.c:1867:33: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
        window->priv->logout_enabled = logout_enabled;
                                     ~ ^~~~~~~~~~~~~~
gs-window-x11.c:1876:38: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
        window->priv->user_switch_enabled = user_switch_enabled;
                                          ~ ^~~~~~~~~~~~~~~~~~~
--
gs-window-x11.c:2286:27: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
        window->priv->obscured = obscured;
                               ~ ^~~~~~~~
--
gs-prefs.c:218:35: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
        prefs->idle_activation_enabled = value;
                                       ~ ^~~~~
gs-prefs.c:225:24: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
        prefs->lock_enabled = value;
                            ~ ^~~~~
gs-prefs.c:232:25: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
        prefs->lock_disabled = value;
                             ~ ^~~~~
gs-prefs.c:239:32: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
        prefs->user_switch_disabled = value;
                                    ~ ^~~~~
gs-prefs.c:246:28: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
        prefs->keyboard_enabled = value;
                                ~ ^~~~~
gs-prefs.c:268:34: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
        prefs->status_message_enabled = enabled;
                                      ~ ^~~~~~~
gs-prefs.c:275:26: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
        prefs->logout_enabled = value;
                              ~ ^~~~~
--
gs-prefs.c:312:31: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
        prefs->user_switch_enabled = value;
                                   ~ ^~~~~
--
gs-grab-x11.c:152:33: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
                grab->priv->no_pointer_grab = no_pointer_grab;
                                            ~ ^~~~~~~~~~~~~~~
gs-grab-x11.c:153:29: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
                grab->priv->hide_cursor = hide_cursor;
                                        ~ ^~~~~~~~~~~
--
gs-fade.c:275:25: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
                fade->priv->enabled = enabled;
                                    ~ ^~~~~~~
--
floaters.c:828:36: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
        screen_saver->should_show_paths = should_show_paths;
                                        ~ ^~~~~~~~~~~~~~~~~
floaters.c:829:38: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
        screen_saver->should_do_rotations = should_do_rotations;
                                          ~ ^~~~~~~~~~~~~~~~~~~
raveit65 commented 2 years ago

I don't see the warnings in my log when using master branch and CFLAGS="-Wsign-conversion" ./autogen.sh --enable-debug --enable-compile-warnings=maximum && make &> make.log.

rbuj commented 2 years ago 
$ CC=clang CFLAGS="-Wconversion -Wunused-macros -Wunused-parameter --enable-debug --enable-compile-warnings=maximum" ./autogen.sh && make &> mate-screensaver.make.log
<cut>
Configure summary:

    mate-screensaver 1.26.0
    =======================

    prefix .......................: /usr
    exec_prefix ..................: ${prefix}
    libdir .......................: /usr/lib64
    bindir .......................: /usr/bin
    sysconfdir ...................: /etc
    localstatedir ................: /var
    datadir ......................: ${prefix}/share
    PAM prefix ...................: /etc
    source code location .........: .
    compiler .....................: clang
    cflags .......................: -g -O0 -Wconversion -Wunused-macros -Wunused-parameter -g -O0
    Warning flags ................: -Wall -Wmissing-prototypes -Wbad-function-cast -Wcast-align -Wextra -Wno-unused-parameter -Wformat-nonliteral -Wmissing-declarations -Wmissing-field-initializers -Wnested-externs -Wpointer-arith -Wredundant-decls -Wshadow -Wstrict-prototypes -Werror=format-security
    Base libs ....................: -lX11 -lXss -ldbus-glib-1 -ldbus-1 -lmate-desktop-2 -lgtk-3 -lgdk-3 -lpangocairo-1.0 -lpango-1.0 -lharfbuzz -latk-1.0 -lcairo-gobject -lcairo -lgdk_pixbuf-2.0 -lstartup-notification-1 -lmate-menu -lgio-2.0 -lgobject-2.0 -lglib-2.0 
    Extension libs ...............:   -lSM -lICE -lXext -lX11  -lXss -lXxf86vm
    Maintainer mode ..............: yes
    Docs enabled .................: no

    GL ...........................: yes

    Screen locking enabled .......: yes
    Show keyboard indicator ......: yes
    systemd support ..............: yes
    elogind support ..............: no
    ConsoleKit support ...........: yes
    libnotify support ............: yes
    PAM support ..................: yes
    bsd_auth(3) support ..........: no
    Have shadow passwords ........: yes
    Have adjunct shadow ..........: no
    Have enhanced shadow .........: no
    Have HPUX shadow .............: no
    Have password helper .........: no
    Authentication scheme ........: pam
    Need setuid dialog ...........: no

Now type `make' to compile mate-screensaver
$ grep "implicit conversion changes signedness: 'gboolean'" -A 2 mate-screensaver.make.log 
gs-watcher-x11.c:206:33: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
                        watcher->priv->idle_notice = in_effect;
                                                   ~ ^~~~~~~~~
gs-watcher-x11.c:233:26: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
                        watcher->priv->idle = is_idle;
                                            ~ ^~~~~~~
gs-watcher-x11.c:272:27: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
                watcher->priv->active = active;
                                      ~ ^~~~~~
gs-watcher-x11.c:312:28: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
                watcher->priv->enabled = enabled;
                                       ~ ^~~~~~~
--
gs-listener-dbus.c:366:31: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
                listener->priv->throttled = throttled;
                                          ~ ^~~~~~~~~
gs-listener-dbus.c:393:33: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
        listener->priv->session_idle = idle;
                                     ~ ^~~~
gs-listener-dbus.c:411:27: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
        listener->priv->active = active;
                               ~ ^~~~~~
gs-listener-dbus.c:499:33: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
        listener->priv->session_idle = idle;
                                     ~ ^~~~
gs-listener-dbus.c:544:40: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
                listener->priv->activation_enabled = enabled;
                                                   ~ ^~~~~~~
--
gs-manager.c:421:30: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
                manager->priv->throttled = throttled;
                                         ~ ^~~~~~~~~
gs-manager.c:465:32: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
                manager->priv->lock_active = lock_active;
                                           ~ ^~~~~~~~~~~
gs-manager.c:498:33: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
                manager->priv->lock_enabled = lock_enabled;
                                            ~ ^~~~~~~~~~~~
gs-manager.c:512:35: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
                manager->priv->logout_enabled = logout_enabled;
                                              ~ ^~~~~~~~~~~~~~
gs-manager.c:530:37: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
                manager->priv->keyboard_enabled = enabled;
                                                ~ ^~~~~~~
gs-manager.c:548:40: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
                manager->priv->user_switch_enabled = user_switch_enabled;
                                                   ~ ^~~~~~~~~~~~~~~~~~~
--
gs-prefs.c:218:35: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
        prefs->idle_activation_enabled = value;
                                       ~ ^~~~~
gs-prefs.c:225:24: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
        prefs->lock_enabled = value;
                            ~ ^~~~~
gs-prefs.c:232:25: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
        prefs->lock_disabled = value;
                             ~ ^~~~~
gs-prefs.c:239:32: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
        prefs->user_switch_disabled = value;
                                    ~ ^~~~~
gs-prefs.c:246:28: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
        prefs->keyboard_enabled = value;
                                ~ ^~~~~
gs-prefs.c:268:34: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
        prefs->status_message_enabled = enabled;
                                      ~ ^~~~~~~
gs-prefs.c:275:26: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
        prefs->logout_enabled = value;
                              ~ ^~~~~
--
gs-prefs.c:312:31: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
        prefs->user_switch_enabled = value;
                                   ~ ^~~~~
--
gs-grab-x11.c:152:33: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
                grab->priv->no_pointer_grab = no_pointer_grab;
                                            ~ ^~~~~~~~~~~~~~~
gs-grab-x11.c:153:29: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
                grab->priv->hide_cursor = hide_cursor;
                                        ~ ^~~~~~~~~~~
--
gs-window-x11.c:1536:28: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
        window->priv->dialog_up = dialog_up;
                                ~ ^~~~~~~~~
--
gs-window-x11.c:1817:31: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
        window->priv->lock_enabled = lock_enabled;
                                   ~ ^~~~~~~~~~~~
gs-window-x11.c:1835:35: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
        window->priv->keyboard_enabled = enabled;
                                       ~ ^~~~~~~
gs-window-x11.c:1862:33: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
        window->priv->logout_enabled = logout_enabled;
                                     ~ ^~~~~~~~~~~~~~
gs-window-x11.c:1871:38: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
        window->priv->user_switch_enabled = user_switch_enabled;
                                          ~ ^~~~~~~~~~~~~~~~~~~
--
gs-window-x11.c:2281:27: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
        window->priv->obscured = obscured;
                               ~ ^~~~~~~~
--
gs-fade.c:275:25: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
                fade->priv->enabled = enabled;
                                    ~ ^~~~~~~
--
floaters.c:828:36: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
        screen_saver->should_show_paths = should_show_paths;
                                        ~ ^~~~~~~~~~~~~~~~~
floaters.c:829:38: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
        screen_saver->should_do_rotations = should_do_rotations;
                                          ~ ^~~~~~~~~~~~~~~~~~~
raveit65 commented 2 years ago

Thanks, i can confirm those warnings are gone.