Closed zhuyaliang closed 3 months ago
@cwendling It looks great. Please merge this PR and initiate a new one. I will review the code as soon as possible
Please merge this PR and initiate a new one.
merge this one first, or replace it with one containing the fixes?
My suggestion is to merge this first, and then review and merge your repair PR
OK, I wouldn't have done it this way but given you changes do work, why not.
@cwendling
I ended up making quite a few changes, see https://github.com/mate-desktop/mate-screensaver/compare/lock-delay...cwendling:mate-screensaver:lock-delay What do you think of those?
This is your labor success, I need your consent
I'm not so worried about attribution :slightly_smiling_face:
Anyway, I opened 3 independent PRs for now:
There's only one change left after these which is removing the "Never" string, but that would conflict with #295 so I'll submit it after this one is either merged or rejected.
@zhuyaliang I ended up making quite a few changes, see https://github.com/mate-desktop/mate-screensaver/compare/lock-delay...cwendling:mate-screensaver:lock-delay What do you think of those?
[edit] if that looks good, maybe I should split them into different PRs, given one is a somewhat orthogonal simplification/cleanup/improvement, and one is entirely unrelated (apart from being in the same dialog)