mate-desktop / mate-screensaver

MATE screen saver and locker
https://mate-desktop.org
GNU General Public License v2.0
48 stars 40 forks source link

Initial accessible object:state-changed:focused event missing from password field when unlocking screen #294

Open joanmarie opened 3 months ago

joanmarie commented 3 months ago

Steps to reproduce:

  1. Acquire Orca from its main branch (see notes below)
  2. Run the unstable version of Orca in a MATE session
  3. Lock the screen and unlock it

Expected results: Orca would announce the password field.

Actual results: Orca only announces a panel.

Notes:

@cwendling: Here's another, please and thank you very much!!

joanmarie commented 3 months ago

This appears to be fixed by https://gitlab.gnome.org/GNOME/gtk/-/merge_requests/7239. Let's hope that lands and lands soon!

cwendling commented 3 months ago

I can't really get an Orca master running just yet here, but adjusting the listener from https://github.com/mate-desktop/caja/issues/1778 I get:

GTK 3.24.38

[window | ] is now focused (focus:)
[panel | ] is now focused (object:state-changed:focused)
[password text | ] is now focused (focus:)

GTK 3.24.42

[window | ] is now focused (object:state-changed:focused)
[window | ] is now focused (object:state-changed:focused)
[panel | ] is now focused (object:state-changed:focused)
[password text | ] is now focused (object:state-changed:focused)
[window | ] is now focused (object:state-changed:focused)

So it looks a bit spammy good (the first even actually happens earlier, likely when locking the screen), but and might be fixed. The last event could look a bit worrying, but it seems to actually happen after unlocking (well, after having hit Return at least), so shouldn't be a problem.

So I'd say this is fixed by upgrading GTK.

joanmarie commented 3 months ago

Cool! @cwendling: Do you happen to know where the duplicates (which, again, I'm not worried about) are coming from?

cwendling commented 3 months ago

@joanmarie here I actually edited my post because there isn't really any duplicate, the first event seem to happen right after when locking (so I guess the black locking window gets active), and I believe the second one is either the unlock dialog or just the same window getting active again because of user interaction. Anyway, those don't seem to be duplicates I think.