search

mate-desktop / mate-session-manager

MATE session manager
https://mate-desktop.org
GNU General Public License v2.0
28 stars 35 forks source link

autostart: fix disabling services in dialog #272

Closed raveit65 closed 3 years ago

raveit65 commented 3 years ago

Steps to reproduce the issue and testing the fix see https://github.com/mate-desktop/mate-session-manager/issues/156#issuecomment-808731386 and https://github.com/mate-desktop/mate-session-manager/issues/156#issuecomment-808893461

lukefromdc commented 3 years ago

This one's important, we need to get this finished and merged before the next unstable point release

raveit65 commented 3 years ago

Yes, this also needs to be go in 1.24 branch.

rbuj commented 3 years ago

IMHO, I don't think it's a good idea to remove the check to avoid adding the app if it already exists from append_app method. I think we need to review the find_by_app method where it compares the applications, as it currently compares the pointers of the objects instead of their content. https://github.com/mate-desktop/mate-session-manager/blob/dcdc9927e3d0b7c3a3475c043693f5c3a933fba3/capplet/gsm-properties-dialog.c#L101

raveit65 commented 3 years ago

I only took that code from https://github.com/mate-desktop/mate-session-manager/issues/156#issuecomment-809557273 But feel free to find a better solution to fix that issue. Btw. i used that patch already in latest fedora package, in result the issue isn't reproducible with standard installation.

raveit65 commented 3 years ago

@rbuj again, I only took that code from #156 (comment) But feel free to find a better solution to fix that issue when you know it better.