Add system desktop files item to automatic startup support

[zhuyaliang]

Fix #150

[lukefromdc]

Hoping we can get one more review

[raveit65]

This black area looks a bit weird, i think it is the GtkViewport inside the scrolled window.

[zhuyaliang]

@raveit65 As expected, we need a border to look more aesthetically pleasing. Set here

g_object_set (dialog->listbox, "margin", 6, NULL);

[raveit65]

I just comment out that line. For me it looks better

So for what this margin is needed? Or better 1px margin?

[raveit65]

I think the problem is the missing border-color from theme. IHMO, it looks weird too with 1px margin.

[zhuyaliang]

removed margin

[raveit65]

I guess what you mean is using border-width for the viewport, which is the parent of the listbox. Changed with gtk-inspector. Same with BlackMate

[zhuyaliang]

@raveit65 Fixed

[raveit65]

Same as before. You added the border-width to GtkListBox. Here the border-width is still ignored. What i meant is adding the border-width to the parent which is GtkViewport. Screenshot with object hierarchy.

But for me this is only a little cosmetic change. I am fine with not using margin or border-width.

More important is that i am missing the search entry when not using headerbars. General Function works fine and i could add firefox and thunderbird desktop files to autostart. But i needed to scroll a long time to the end of the list to select thunderbird. Is the search-entry really only available for csd (headerbar) dialog?

And i am wondering of using msm term. Nearly all other functions or files are using gsm term. I do not really care about and i don't want to block it when you think it is OK, but it looks like a bit inconsistent usage of naming.

[raveit65]

Hmm, full functionality works only with:

[rave@mother ~]$ gsettings get org.mate.interface gtk-dialogs-use-header
true

But the gsettings key is disabled as default in MATE.

[zhuyaliang]

@raveit65 Yes, the search function only works when using dialog headerbar mode，gsm is the abbreviation for gnome session manager, and msm is the abbreviation for mate session manager. I think using msm is more appropriate

[raveit65]

I can confirm that the border is there with latest forced-push.

@raveit65 Yes, the search function only works when using dialog headerbar mode, .......

Mate default does not use headerbars for dialog windows. In 2014 we decided not use headerbars for Mate applications for several reasons. https://github.com/mate-desktop/mate-desktop/pull/129 https://github.com/mate-desktop/mate-desktop/commit/e9ae72f43c0c5d859685c29a926284edb5455d4e So most users of Mate will not see your searchbar.

Why not using a normal decorated dialog-window with a searchbar at the bottom?

When we want to use headerbars for dialog windows than this is a general design question and needs to be discussed by the team, ihmo.

Note: Why is the searchbar not visible as default in headerbar-dialog? An extra click on the search button to show the searchbar is unneeded and one click too much for me ;-)

[lukefromdc]

We should be able to pack that searchbox into a box at the top or bottom of the UI instead of the headerbar with little difficult. Similar to what I did for the dictionary applet in wayland, where we cannot not focus the entry if it is on the panel itself, so I moved it to the popup dialog.

Headerbars clash with the normal MATE server-side decorated UI which is why we do not use them by default. I am still looking for a way to disable them is wayland where for obvious reasons we don't have an xsettings manager

[lukefromdc]

Doesn't seem to need any special theme support, looks quite nice in my own UbuntuStudio_Legacy theme:

[zhuyaliang]

searchbar visible as default in headerbar-dialog

[lukefromdc]

I can confirm we now get a visible searchbox underneath the non-CSD decorations

[raveit65]

Thanks, both versions non-csd and csd dialog are working with with a active searchbar now.