remove extra glib version check from build conf

mate-desktop / mate-settings-daemon

MATE settings daemon

https://mate-desktop.org

GNU General Public License v2.0

43 stars 48 forks source link

remove extra glib version check from build conf #130

Closed alexandervdm closed 7 years ago

alexandervdm commented 8 years ago

configure.ac runs the same glib version check twice. This commit removes the second code block.

raveit65 commented 8 years ago

@alexandervdm Maybe it's better to remove only the AC_DEFINE([GLIB_VERSION_MAX_ALLOWED] from configure.ac, which is pretty nonsense because it produce only build warnings and nobody takes care, and remove the checks in the other place?

monsta commented 7 years ago

I think we can remove both. "Warn on use of APIs deprecated before GLib 2.36" - we already get such warnings anyway.

monsta commented 7 years ago

So it was a duplicate block, I didn't get it at first. Merged in https://github.com/mate-desktop/mate-settings-daemon/commit/be722bbe7c5cc68329c4431b533708f625c0472b - but I think we can remove such checks completely anyway.