port to GtkStyleContext and a few other fixes for warnings

raveit65 commented 8 years ago

complete port of media-keys to GtkStyleContext
port msd-locate-pointer to GtkStyleContext
add OSD style class to media-keys
media-keys: do not use a hard coded setting for for all elements of the OSD window
media-keys: fixes a -Wincompatible-pointer-types warning from previous commit
mouse: fix deprecated gtk_style_context_get_background_color
xsettings: fix build warning -Wdiscarded-qualifiers

Mainly our OSD windows use now osd settings from themes instead of old hard coded setting from gtk2 code which didn't work for gtk3. If your theme does not support osd well than you can use this example setting.

MsdOsdWindow.background.osd {
    border-radius: 10%;
}

MsdOsdWindow.background.osd.trough {
    background-color: @osd_trough_bg;
    border-style: solid;
    border-width: 1px;
    border-color: shade (@theme_selected_bg_color, 0.4);
}

MsdOsdWindow.background.osd.progressbar {
    background-color: @theme_selected_bg_color;
}

This works for all gtk+3 versions, no need to change something for >= gtk+-3.20 :) Note, our themes use wrong selectors for OSD in 3.20/22/master branch, but with previous gtk+ versions they work out of box. I will fix that soon. Btw. this is all for using compositor, w/o compositor it use some hard coded stuff. But fixing that is the next step, i don't want to make the PR more huge.

@dnk I don't think we need the style class .window-frame after you add .osd class. Double setting.

@monsta @lukefromdc @dnk Please test. If you want to make an improvement please commit or do a PR here ;)

monsta commented 8 years ago

So the first commit adds quite a lot of code to msd-osd-window.c (and the calls of these functions in other files), but the last commit removes most of it... Maybe squash them into one commit? Also LIGHTNESS_MULT and DARKNESS_MULT can be removed there too.

raveit65 commented 8 years ago

done :)

raveit65 commented 8 years ago

ok, as everbody is happy now i will merge it.

lukefromdc commented 8 years ago

https://github.com/mate-desktop/mate-themes/commit/374a117a2faf86dad36586dcdf87d8324dead5be was necessary to fix square corners and unreadable progressbars in BlackMATE. Similar work done in my UbuntuStudio_Legacy theme.

On 6/5/2016 at 2:56 PM, "raveit65" notifications@github.com wrote:

Merged #150.

You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub: https://github.com/mate-desktop/mate-settings- daemon/pull/150#event-682225781

mate-desktop / mate-settings-daemon

port to GtkStyleContext and a few other fixes for warnings #150