search

mate-desktop / mate-settings-daemon

MATE settings daemon
https://mate-desktop.org
GNU General Public License v2.0
43 stars 48 forks source link

Fixes for background drawing #169

Closed XRevan86 closed 7 years ago

XRevan86 commented 7 years ago

This fixes directory background drawing in #506, fixes compiz-reloaded/compiz#40 (desktop background issues with Compiz 0.8.x) and fixes background fading. Caja now draws the desktop background again and the gap in code between GTK+ 3.22 and previous versions is removed. Other parts of the change: mate-desktop/mate-desktop#249, mate-desktop/caja#731.

raveit65 commented 7 years ago

Seems to work fine :-) I tested all 3 PRs with f24 (gtk+-3.20) and fedora rawhide (f26) with gtk+-3.22. As fedora rawhide is quite buggy in this early state i back ported the changes to 1.16 and created branches for every package. Than i can test this on stable f25 with 1.16.x, also i can ask some guys in fedora-forum to test all with compiz. I am not sure if we want to merge it to 1.16 too as it is a massive change, but i really need patches for 1.16 to fix broken compiz in f25. No need let the users wait 6 months for a fix which comes regular with mate-1.18 for f26.

monsta commented 7 years ago

Ok, this change doesn't affect older GTK+ versions, so it's the same as before with GTK+ 3.18.9 here. I need to test it with 3.22 to see any changes.

monsta commented 7 years ago

Using this PR on its own, or together with mate-desktop PR, but w/o Caja PR doesn't introduce any crashes with GTK+ 3.22.8. I only got black desktop background, but otherwise Caja works. I'm just trying to test possible partial upgrade situations...