Prevent media-keys bindings from swallowing modifier keys

[vkareh]

This changes how the media-keys manager determines successful key-bindings from KeyRelease to KeyPress so that it does not conflict with third-party applications that want to use modifier keys as global key-bindings. We've already done this change for general keybindings and marco.

It also cleans up a bunch of deprecation warnings.

Related:

• ubuntu-mate/mate-menu/pull/33
• solus-project/brisk-menu/pull/88

[raveit65]

I guess this can be cherry-picked to 1.20 as it is a bugfix. Not sure about 1.18.....

[monsta]

Oh great, they indeed deprecated some more stuff in another 3.22.x release. https://github.com/GNOME/gtk/commit/176c1046cb1388f70ea257ac15b7ac537d219545

Surely we don't have enough build warnings already.

[monsta]

The deprecation fixes should've really been in a separate commit... it's not pickable as is for 1.18.

[monsta]

Ok, modified for 1.18 in 600082f15aabbc3c83e0b7a5552ed28df49ed4df.

[lukefromdc]

Speaking of GTK warnings, at least the upcoming GTK 3.22.30 will remove those nasty "how can the code..." allocation warnings unless debug is enabled

[monsta]

Unbelievable :grin: