search

mate-desktop / mate-settings-daemon

MATE settings daemon
https://mate-desktop.org
GNU General Public License v2.0
43 stars 48 forks source link

media-keys: Simplify touchpad OSD #239

Closed zhangxianwei8 closed 6 years ago

zhangxianwei8 commented 6 years ago

This PR is ported from gnome-settings-daemon: https://github.com/GNOME/gnome-settings-daemon/commit/fe41be4f980dee86a594105398a63cb3e1b4c689

zhangxianwei8 commented 6 years ago

@raveit65 Could you review this PR?

raveit65 commented 6 years ago

I noticed another issue but this isn't related to PR, i see the same behavior in master. If start my notebook with touchpad disable, i am using the physical switch (button) from my notebook, i can't enable the touchpad inside mate session. I need to restart the whole system again. Not sure if the problem is related to my hardware (msi fx700) I don't use the touchpad normal, so i never noticed this problem. Any way, issue exists with master too, so it isn't related to this PR.

zhangxianwei8 commented 6 years ago

I noticed another issue but this isn't related to PR, i see the same behavior in master. If start my notebook with touchpad disable, i am using the physical switch (button) from my notebook, i can't enable the touchpad inside mate session. I need to restart the whole system again. Not sure if the problem is related to my hardware (msi fx700) I don't use the touchpad normal, so i never noticed this problem. Any way, issue exists with master too, so it isn't related to this PR.

What is the kernel version? Maybe it is the msi keyboard driver bug? Can the 'xev' or 'evtest' catch input event?

raveit65 commented 6 years ago

It looks like that events are reversed to current settings if i start the box with

[rave@satellite ~]$ gsettings get org.mate.peripherals-touchpad touchpad-enabled
false

Now i see touchpad events with evtest but touchpad doesn't work in session. If i enable the touchpad with the physical switch or with gsettings, i see the touchpad-enable osd but i don't see any event with evtest and touchpad don't work.

When i restart the system with

[rave@satellite ~]$ gsettings get org.mate.peripherals-touchpad touchpad-enabled
true

everything works as expected. Only restarting session doesn't help. [rave@satellite ~]$ uname -r 4.18.11-200.fc28.x86_64

zhangxianwei8 commented 6 years ago

If I set org.mate.peripherals-touchpad touchpad-enabled to false and restart system, when I press touchpad button twice, the touchpad works as expected (enabled and disabled) and osd icon displays on/off too. I don't know why touchpad works when set touchpad-enabled to false.The laptop is Lenovo E43.

raveit65 commented 6 years ago

np, i don't use the touchpad normal :)