search

mate-desktop / mate-settings-daemon

MATE settings daemon
https://mate-desktop.org
GNU General Public License v2.0
43 stars 47 forks source link

Remove unuseful argument and test for screen brightness OSD icons #246

Closed zhangxianwei8 closed 5 years ago

zhangxianwei8 commented 5 years ago

Screen brightness OSD has been moved from m-s-d to m-p-m, see: https://github.com/mate-desktop/mate-power-manager/commit/4fd2ae34e50e63ef562356f804dbdea81341f4e2 So remove test for brightness OSD icons in m-s-d.

Sence brightness OSD has been moved to m-p-m, there is no any situation to control show_level in msd_media_keys_window_set_action_custom, should remove this argument.

zhangxianwei8 commented 5 years ago

Could you review this PR please?

lukefromdc commented 5 years ago

I don't have working brightness keys on my only working laptop

zhangxianwei8 commented 5 years ago

You can try to test by using:

xdotool key XF86MonBrightnessUp xdotool key XF86MonBrightnessDown

zhangxianwei8 commented 5 years ago

Maybe @raveit65 can test it?

lukefromdc commented 5 years ago

I get no response from those test commands on a desktop, assume they work only on laptops?