search

mate-desktop / mate-settings-daemon

MATE settings daemon
https://mate-desktop.org
GNU General Public License v2.0
43 stars 47 forks source link

msd-xrdb-manager: realize the widget #254

Closed sc0w closed 5 years ago

sc0w commented 5 years ago

Fixes https://github.com/mate-desktop/mate-settings-daemon/pull/248#issuecomment-443527197

sc0w commented 5 years ago

@lukefromdc you can test with editres (try to run it), and see the window without/with the PR

lukefromdc commented 5 years ago

OK, the need for this is confirmed, as without the PR we get nearly white-on-white text

lukefromdc commented 5 years ago

Oh yeah-this affects git-gui, I just had not rebuilt my normal install yet with the previous commit, had only tested it and not run git-gui during that test or known it would be affected. Removing this plugin will make git-gui hard to use due to low text contrast

lukefromdc commented 5 years ago

On further testing, I confirmed that git-gui is plently readable if this plugin is entirely disabled(rather than broken) but falls all the way back to its default theme. While my theme is not completely applied, enough of it is to make git-gui look better on my desktop than it otherwise would.

Still, removing this plugin makes git-gui less attractive, not hard to use. A BROKEN plugin made it hard to use