fixed make distcheck on debian

yetist commented 5 years ago

Fix make distcheck fail on debian. see #259

yetist commented 5 years ago

@lukefromdc

Yes, I just let make distcheck pass on travis in this PR.

The real issue is that there is a bug in intltool on debian, please see https://github.com/mate-desktop/mate-settings-daemon/pull/259#issuecomment-462403038 and https://github.com/mate-desktop/mate-settings-daemon/pull/259#issuecomment-463034620

If debian can patch intltools, all problems will be solved, and the patch can be get from here:

Fedora: https://src.fedoraproject.org/rpms/intltool/blob/master/f/intltool_distcheck-fix.patch
Archlinux: https://git.archlinux.org/svntogit/packages.git/tree/trunk/intltool_distcheck-fix.patch?h=packages/intltool
Ubuntu: path named no-guess-builddir.patch in this tarballs: http://archive.ubuntu.com/ubuntu/pool/universe/i/intltool/intltool_0.51.0-5ubuntu1.debian.tar.xz

Maybe you have permission to fix intltools for debian?

lukefromdc commented 5 years ago

I am not a Debian maintaner at all, and am not connected to the Debian project. Just running it, with a lot of modifications including locally compiled kernel, cypher stack, glib, gtk3, and compiz as well as MATE

yetist commented 5 years ago

I thought you were, ok, it looks like we need to report the bug to debian.

raveit65 commented 5 years ago

@monsta debian got a problem

raveit65 commented 5 years ago

Let's start with merging debian.sh from mate-dev-scripts.

raveit65 commented 5 years ago

Done https://github.com/mate-desktop/mate-dev-scripts/commit/e41e38b90cbdbda47ff70369b20c8de7d1e9d851 Now PR can be updated.

yetist commented 5 years ago

OK, it is ready to merge.

mate-desktop / mate-settings-daemon

fixed make distcheck on debian #262