search

mate-desktop / mate-settings-daemon

MATE settings daemon
https://mate-desktop.org
GNU General Public License v2.0
43 stars 48 forks source link

Move D-Bus conf file to $(datadir)/dbus-1/system.d #296

Closed worldofpeace closed 4 years ago

worldofpeace commented 5 years ago

Since D-Bus 1.9.18 configuration files installed by third-party should go in share/dbus-1/system.d. The old location is for sysadmin overrides.

raveit65 commented 5 years ago

Do you have a link to docs about this change?

worldofpeace commented 5 years ago

See https://dbus.freedesktop.org/doc/dbus-daemon.1.html CONFIGURATION FILE

The standard system bus normally reads additional XML files from /usr/share/dbus-1/system.d. Third-party packages should install the default policies necessary for correct operation into that directory, which has been supported since dbus 1.10 (released in 2015). The standard system bus normally also reads XML files from /etc/dbus-1/system.d, which should be used by system administrators if they wish to override default policies. Third-party packages would historically install XML files into /etc/dbus-1/system.d, but this practice is now considered to be deprecated: that directory should be treated as reserved for the system administrator.

lukefromdc commented 5 years ago

How do I test this? Does Pluma's date/time plugin get its information from this and provide a valid test, or does something else use it? The panel clock seems to work the same even if I disable this plugin in dconf-editor and restart m-s-d

worldofpeace commented 5 years ago

I believe the .conf file that is installed is https://github.com/mate-desktop/mate-settings-daemon/blob/f58866e5d85915ba8e957cd0c6054c392f9d3ffa/plugins/datetime/org.mate.SettingsDaemon.DateTimeMechanism.conf

That conf file says

<!-- Only root can own the service -->

<!-- Allow anyone to invoke methods on the interfaces -->

So you have to check if root owns org.mate.SettingsDaemon.DateTimeMechanism and if anyone can invoke methods on the interface. Probably could test with d-feet.

lukefromdc commented 5 years ago

I have no idea what d-feet is, but thanks for the instructions. Will leave this for someone who knows what they are doing for a proper test. Might get to a go-nogo "does it function" test but out of time tonight.

worldofpeace commented 5 years ago

d-feet is a dbus debugger

Pretty useful tool to play around with dbus as you'd need to here.

eworm-de commented 4 years ago

This one is wrong, see #303. If you want to change the default please do in configure.ac.

worldofpeace commented 4 years ago

Didn't notice that, will PR a default change after that is merged :+1: