search

mate-desktop / mate-settings-daemon

MATE settings daemon
https://mate-desktop.org
GNU General Public License v2.0
44 stars 47 forks source link

Have 'Super+P' trigger a video mode switch. #297

Closed flexiondotorg closed 2 years ago

flexiondotorg commented 4 years ago

Newer Dell and HP systems have a BIOS which causes FN+F8 to send the literal Super+P scan codes instead of a KEY_VIDEOMODE scan code. See https://pad.lv/539477 for the background.

vkareh commented 4 years ago

Why oh why!! I use Super+P regularly (for corner tiling), a lot more than video mode switches, why would Dell/HP do that?!!?

This patch works, but I would suggest putting it behind a gsettings flag, or (if possible) detect whether the system uses that abherration of a key combo and then enable/disable accordingly.

I have a Lenovo that doesn't suffer from this mis-design, and it would make me sad to lose Super+P on that system...

On a side note, the Keyboard Shortcuts app still lets me map Super+P with no problems (and my laptop does both, corner tiling and video mode switch), but that's outside the scope of this change.

monsta commented 4 years ago

Please no. Both LP and gnome-bugzilla reports are full of comments from users who experienced problems due to this surprise hardcoded keybinding. Let's not repeat a mistake done 9 years ago.

flexiondotorg commented 4 years ago

Super+P is now an industry standard.

vkareh commented 4 years ago

It might be, but not all computers have it. I have a feeling it's only laptops and only certain brands/models.

My Dell XPS suffers from this, but my Lenovo P50 (which is newer) doesn't.

Can we put it behind a gsettings toggle (even if defaulted to Super+P) so that I can turn it off?

Another alternative is to not hard-code it in m-s-d, but provide it as a configurable shortcut in the Keyboard Shortcuts app, and default it to Super+P.

On September 21, 2019 8:29:11 AM EDT, Martin Wimpress notifications@github.com wrote:

Super+P is now an industry standard.

-- You are receiving this because your review was requested. Reply to this email directly or view it on GitHub: https://github.com/mate-desktop/mate-settings-daemon/pull/297#issuecomment-533794304

monsta commented 4 years ago

I doubt it's some standard if only a few laptop vendors have it. We'll get tons of reports from desktop users for this.

vkareh commented 4 years ago

Is there a way to determine what brand/model laptop the user is running? Sort of like a similar database used to detect monitor metadata?

gm10 commented 4 years ago

For what it's worth, my Asus laptop also binds Fn+F8 to Super+P, the same keybind that Windows uses for the video mode switch. So the combination as such is fairly standard and expected indeed and some sort of support for it, optional or not, would be nice.

lukefromdc commented 2 years ago

Closing due to lack of activity and multiple requests for changes. Can be reopened if someone wants to put this behind a gsettings switch and not make it the default.