mate-desktop / mate-settings-daemon

MATE settings daemon
https://mate-desktop.org
GNU General Public License v2.0
43 stars 48 forks source link

add G_GNUC_UNUSED in some unused parameters #332

Closed sc0w closed 4 years ago

sc0w commented 4 years ago

mark parameters as unused with G_GNUC_UNUSED called by G_CALLBACK inside g_signal_connect

sc0w commented 4 years ago

@rbuj there is no indentation problems, you can see the files locally or at github website, the indentations you mentioned are the same as before, it is ok

raveit65 commented 4 years ago

@sc0w You`re right, the indentations were wrong before. But why not fixing it when you already touch that code? Now another person needs to work at the same places to fix code-style.

sc0w commented 4 years ago

@raveit65

You`re right, the indentations were wrong before. But why not fixing it when you already touch that code? Now another person needs to work at the same places to fix code-style.

the indentation are ok before and now for me

raveit65 commented 4 years ago

@raveit65

You`re right, the indentations were wrong before. But why not fixing it when you already touch that code? Now another person needs to work at the same places to fix code-style.

the indentation are ok before and now for me

Ok, you have a bad day.....

sc0w commented 4 years ago

@raveit65 This is a happy and nice day for me :)

raveit65 commented 4 years ago

... unsubscribe.

Edit: Sigh, i left discussion because your attitude. ... and you like that

rbuj commented 4 years ago

About indent... @sc0w you do not maintain the same criteria on this MR and other MR you reviewed. You ask other developers to take care about code indent while you ignore your own suggestions.

@mate-desktop/core-team

sc0w commented 4 years ago

unsbuscribing...