mate-desktop / mate-settings-daemon

MATE settings daemon
https://mate-desktop.org
GNU General Public License v2.0
43 stars 48 forks source link

main: Do not override detailed_signal for debugging #334

Closed rbuj closed 4 years ago

rbuj commented 4 years ago

Test: enable debugging

$ gsettings get org.mate.debug mate-settings-daemon
false
$ gsettings set org.mate.debug mate-settings-daemon true

Screenshot at 2020-08-15 15-44-40

muktupavels commented 4 years ago

I don't understand commit message title... What is overridden? Where?

rbuj commented 4 years ago

@muktupavels detailed_signal is "changed::DEBUG_KEY" on https://developer.gnome.org/gobject/stable/gobject-Signals.html#g-signal-connect, being "changed" the signal-name and DEBUG_KEY the detail. You can also check that value of key parameter is DEBUG_KEY on eclipse right side panel, variables. https://github.com/mate-desktop/mate-settings-daemon/blob/cc4242f58fe38313a3176cf8a76b074110e1d874/mate-settings-daemon/main.c#L486

https://github.com/mate-desktop/mate-settings-daemon/blob/cc4242f58fe38313a3176cf8a76b074110e1d874/mate-settings-daemon/main.c#L49

muktupavels commented 4 years ago

You still did not answer what is overridden...

rbuj commented 4 years ago

You still did not answer what is overridden...

key

rbuj commented 4 years ago

I only changed two lines... can you see where? and why is it overridden?