mate-desktop / mate-settings-daemon

MATE settings daemon
https://mate-desktop.org
GNU General Public License v2.0
43 stars 48 forks source link

housekeeping: disconnect manager's changed settings signal on finalize #376

Closed rbuj closed 2 years ago

rbuj commented 2 years ago

It also fixes a SEGV when logging out MATE session because the cleanup functions were called twice.

L-U-T-i commented 2 years ago

Building for Rocky Linux 8.5 (glib2 2.56) throws out the following error:

msd-housekeeping-manager.c: In function 'msd_housekeeping_manager_finalize':
msd-housekeeping-manager.c:271:22: error: 'MsdHousekeepingManager' {aka 'struct _MsdHousekeepingManager'} has no member named 'sconfig_listener_id'; did you mean 'config_listener_id'?
         if (manager->sconfig_listener_id != 0) {
                      ^~~~~~~~~~~~~~~~~~~
                      config_listener_id
msd-housekeeping-manager.c:273:55: error: 'MsdHousekeepingManager' {aka 'struct _MsdHousekeepingManager'} has no member named 'sconfig_listener_id'; did you mean 'config_listener_id'?
                                              manager->sconfig_listener_id);
                                                       ^~~~~~~~~~~~~~~~~~~
                                                       config_listener_id
msd-housekeeping-manager.c:274:26: error: 'MsdHousekeepingManager' {aka 'struct _MsdHousekeepingManager'} has no member named 'sconfig_listener_id'; did you mean 'config_listener_id'?
                 manager->sconfig_listener_id = 0;
                          ^~~~~~~~~~~~~~~~~~~
                          config_listener_id
make[3]: *** [Makefile:584: libhousekeeping_la-msd-housekeeping-manager.lo] Error 1

I guess there is a typo and it should be manager->config_listener_id instead of manager->sconfig_listener_id?

I've replaced it, and it builds fine after...

rbuj commented 2 years ago

@L-U-T-i thank you very much for the notice

L-U-T-i commented 2 years ago

@rbuj thank you for all the work you do for us