search

mate-desktop / mate-settings-daemon

MATE settings daemon
https://mate-desktop.org
GNU General Public License v2.0
43 stars 48 forks source link

smartcard: migrate from dbus-glib to GDBus #405

Closed yetist closed 1 year ago

yetist commented 1 year ago

Although it looks like it's done, I don't know how to test it, maybe a smart card?

raveit65 commented 1 year ago

Although it looks like it's done, I don't know how to test it, maybe a smart card?

You need a smartcard(rfid)-reader and the linux software called openSC. I will buy this cheap reader from your country, maybe it works :) https://www.ebay.de/itm/314610568693 @mate-desktop/core-team Anyone have a smartcard-reader?

lukefromdc commented 1 year ago

I also do not have a smartcard reader to test this, and I do not shop online. Looks like @raveit65 can test it for function though, so if it works for the both the author and one tester we cover at least two setups.

raveit65 commented 1 year ago

I received the reader and i could read some minimal infos from one card that i have. But after reading the code of the plugin i think it is used for a account login with a smartcard. No idea how this should work with Mate and what kind of cards are needed. @yetist Is this plugin independent from https://github.com/mate-desktop/mate-settings-daemon/pull/406 ? I saw #include "mate-settings-plugin.h" in msd-smartcard-plugin.c

yetist commented 1 year ago

I received the reader and i could read some minimal infos from one card that i have. But after reading the code of the plugin i think it is used for a account login with a smartcard. No idea how this should work with Mate and what kind of cards are needed. @yetist Is this plugin independent from #406 ? I saw #include "mate-settings-plugin.h" in msd-smartcard-plugin.c

This PR should not need to depend on #406 and can be tested directly. In addition, the gdbus branch(#324) will integrate all PRs and can be tested as a whole.

yetist commented 1 year ago

https://access.redhat.com/documentation/en-us/red_hat_enterprise_linux/9/html-single/managing_smart_card_authentication/index#logging_in_to_gdm_with_lock_on_removal

If you are logged in to GDM and you remove your smart card, screen lock is enabled and you must reinsert your smart card and authenticate with the PIN to unlock the screen.

I'm guessing this is how it works on mate-settings-daemon.

raveit65 commented 1 year ago

If really a company use Mate with a smartcard login we can debug it when they report an issue for this change. But i am thinking that nobody use this plugin. So, it is save to merge it after a review.

raveit65 commented 1 year ago

Any other reviewer or should i merge it?