mate-desktop / mate-settings-daemon

MATE settings daemon
https://mate-desktop.org
GNU General Public License v2.0
44 stars 46 forks source link

msd: migrate from dbus-glib to GDBus #406

Closed yetist closed 9 months ago

yetist commented 9 months ago

Pleae just test, but don't merge now.

raveit65 commented 9 months ago

I noticed that with this PR the xrandr plugin doesn't work anymore. Probably others too.... So, this can't be merged without porting those plugins first. I have disabled the commit on my production system for the moment. I 'll enable it when it is needed to test other plugins.

lukefromdc commented 9 months ago

So THAT's why I got a hugely over-scaled screen on next boot! I thought it was a random problem of the kind I occasionally get

raveit65 commented 9 months ago

Restarting the daemon is complete broken.

[rave@mother ~]$ /usr/libexec/mate-settings-daemon --replace

** (mate-settings-daemon:11323): WARNING **: 11:41:58.946: You can only run one xsettings manager at a time; exiting

** (mate-settings-daemon:11323): WARNING **: 11:41:58.946: Unable to start xsettings manager: Could not initialize xsettings manager.

** (mate-settings-daemon:11323): WARNING **: 11:41:58.953: Grab failed for some keys, another application may already have access the them.

(mate-settings-daemon:11323): GLib-GObject-CRITICAL **: 11:41:59.033: g_object_unref: assertion 'G_IS_OBJECT (object)' failed

(mate-settings-daemon:11323): GLib-GObject-CRITICAL **: 11:41:59.033: g_object_unref: assertion 'G_IS_OBJECT (object)' failed

(mate-settings-daemon:11323): GLib-GObject-CRITICAL **: 11:41:59.033: g_object_unref: assertion 'G_IS_OBJECT (object)' failed

(mate-settings-daemon:11323): GLib-CRITICAL **: 11:41:59.034: g_hash_table_destroy: assertion 'hash_table != NULL' failed

(mate-settings-daemon:11323): GLib-GIO-WARNING **: 11:41:59.034: Unexpected reply 3 when releasing name org.mate.SettingsDaemon

(mate-settings-daemon:11323): GLib-GIO-WARNING **: 11:41:59.036: Unexpected reply 3 when releasing name org.mate.SettingsDaemon
[rave@mother ~]$

I am using latest versions from those PRs for this test. https://github.com/mate-desktop/mate-settings-daemon/pull/403 https://github.com/mate-desktop/mate-settings-daemon/pull/406 https://github.com/mate-desktop/mate-settings-daemon/pull/404 https://github.com/mate-desktop/mate-settings-daemon/pull/405 https://github.com/mate-desktop/mate-settings-daemon/pull/407

Maybe there is a port of a plugin missing?

Edit: The daemon has the same PID as before.

raveit65 commented 9 months ago

With m-s-d-1.27.0 we have this normal output (warnings can be ignored)

[rave@mother ~]$ /usr/libexec/mate-settings-daemon --replace

** (mate-settings-daemon:17360): WARNING **: 12:08:59.689: There was a problem when setting QT_FONT_DPI=96: GDBus.Error:org.gnome.SessionManager.NotInInitialization: Setenv interface is only available during the Initialization phase

** (mate-settings-daemon:17360): WARNING **: 12:08:59.690: There was a problem when setting QT_SCALE_FACTOR=2: GDBus.Error:org.gnome.SessionManager.NotInInitialization: Setenv interface is only available during the Initialization phase
[1695895739,000,xklavier.c:xkl_engine_start_listen/]    The backend does not require manual layout management - but it is provided by the application
raveit65 commented 9 months ago

Daemon restarts fine when using only 1.27.0 + gdbus-date-time- ,gdbus-smartcard-commit.

yetist commented 9 months ago

It looks like this PR is not done and needs to continue to be completed.

lukefromdc commented 9 months ago

Looks like the Travis build failures are a bad URL well before this code is ever touched: ERROR: Could not install requirement PyGithub from https://files.pythonhosted.org/packages/be/04/810d131be173cba445d3658a45512b2b2b3d0960d52c4a300d6ec5e00f52/PyGithub-2.1.1-py3-none-any.whl#sha256=4b528d5d6f35e991ea5fd3f942f58748f24938805cb7fcf24486546637917337 because of HTTP error 502 Server Error: Gateway Error for url: https://files.pythonhosted.org/packages/be/04/810d131be173cba445d3658a45512b2b2b3d0960d52c4a300d6ec5e00f52/PyGithub-2.1.1-py3-none-any.whl for URL https://files.pythonhosted.org/packages/be/04/810d131be173cba445d3658a45512b2b2b3d0960d52c4a300d6ec5e00f52/PyGithub-2.1.1-py3-none-any.whl#sha256=4b528d5d6f35e991ea5fd3f942f58748f24938805cb7fcf24486546637917337 (from https://pypi.org/simple/pygithub/) (requires-python:>=3.7)

yetist commented 9 months ago

404 #406 #407 #408 should be put together for testing

lukefromdc commented 9 months ago

I think the idea of splitting these up may have been a mistake, as it turned out they were more interconnected that perhaps had been thought

raveit65 commented 9 months ago

Restarting the daemon works fine now.

raveit65 commented 9 months ago

I will merge all 4 PRs as nobody else want to review them.