search

mate-desktop / mate-settings-daemon

MATE settings daemon
https://mate-desktop.org
GNU General Public License v2.0
43 stars 48 forks source link

add a keyboard shortcut to start a screen reader #416

Closed vojtapolasek closed 2 months ago

vojtapolasek commented 4 months ago

The keybinding is alt+super+s.

This is my first contribution here, I am not sure how to verify my changes. Help appreciated.

cwendling commented 4 months ago

The keybinding is alt+super+s.

This looks legit. It's the "new" GNOME default I believe, and it's the override Debian ships for a long time; and the syntax look OK.

This is my first contribution here, I am not sure how to verify my changes. Help appreciated.

You should rebuild and install your changes locally and verify they work. Building mate-settings-daemon is not terribly hard, and if you're rather used to building RPMs you just need to use the snapshot from your PR and verify it works. If you need more specific information, ask away.

lukefromdc commented 4 months ago

The Travis fail in Debian came from a noninstallable package, we can presumably ignore it for the purpose of this PR:

Package policykit-1 is not available, but is referred to by another package.
This may mean that the package is missing, has been obsoleted, or
 only available from another source

However the following packages replace it:

  polkitd pkexec

E: Package 'policykit-1' has no installation candidate

Note that in Debian Unstable we still have a "transitional package" by this name that depends on the current polkitd and pkexec. I guess that was removed from Debian Testing while still being present in Debian Unstable.

lukefromdc commented 4 months ago

I just fixed the Debian build failure in master, that had nothing to do with this PR so we can ignore it

vojtapolasek commented 2 months ago

Hello, I rebased. Could we merge this please?

cwendling commented 2 months ago

WFM and it's a good addition to stock MATE, thanks for your contribution!