mate-desktop / mate-system-monitor

Process viewer and system resource monitor for MATE
https://mate-desktop.org
GNU General Public License v2.0
45 stars 27 forks source link

Settings for "Information Fields" not saved #242

Closed darealshinji closed 2 years ago

darealshinji commented 2 years ago

Expected behaviour

Should save my settings for the selected Information Fields

Actual behaviour

Doesn't save these settings

Steps to reproduce the behaviour

Go to settings, disable i.e. "% CPU", close app and open app again, then the "% CPU" field will be activated again.

MATE general version

MATE 1.26.0

Package version

1.26.0-1

Linux Distribution

Ubuntu MATE 22.04 LTS x86_64

Link to bugreport of your Distribution (requirement)

Kunutza commented 2 years ago

I have the exact same issue

vjayer commented 2 years ago

Same here. In the meantime for a workaround, is there a config file we can modify to change the defaults?

rbuj commented 2 years ago

In the quick test I performed, everything works correctly: After disabling "% CPU" column in "System Monitor Preferences" dialog:

$ dconf dump /org/mate/system-monitor/proctree/
[/]
col-8-visible=false

col-8-visible is the 9th element in titles array, zero-based numbering: https://github.com/mate-desktop/mate-system-monitor/blob/2b767be06f5b5b602e56740275784bb9bf3474c3/src/proctable.cpp#L261

mbkma commented 2 years ago

@rbuj are you on master or on 1.26.0? Because I just found that this PR https://github.com/mate-desktop/mate-system-monitor/pull/224 might have fixed this and should be in a new release 1.26.1.

rbuj commented 2 years ago

I tried it on version 1.26.0, using the fedora 36 package.

rbuj commented 2 years ago

I reproduced the issue using --disable-wnck, and #224 fixed it, since the index COL_MEMXSERVER must be avoided.

CFLAGS="-Wconversion -Wunused-macros -Wunused-parameter" CXX=clang++ CC=clang ./autogen.sh --prefix=/usr --enable-debug --enable-compile-warnings=maximum --disable-wnck && make &> make.log && sudo make install
mbkma commented 2 years ago

ok, then #224 should be included in a new 1.26.1 release.