search

mate-desktop / mate-terminal

The MATE Terminal Emulator
http://www.mate-desktop.org
GNU General Public License v3.0
134 stars 73 forks source link

Explicitly enable bright bold to match new VTE versions #279

Closed micheal65536 closed 5 years ago

micheal65536 commented 5 years ago

Fixes #278

sc0w commented 5 years ago

NOTE: the function vte_terminal_set_bold_is_bright works since VTE 0.52 and mate-terminal requires 0.48

@micheal65536 I think that line requires #if VTE_CHECK_VERSION (0, 52, 0)

micheal65536 commented 5 years ago

@sc0w Thanks for pointing this out. I meant to say that it requires at least VTE 0.52 but I forgot. Also wasn't sure what version MATE terminal officially requires, if upgrading the required version is acceptable, or how to conditionally check the version.

I will add the version check macro as soon as I get a chance.

micheal65536 commented 5 years ago

@lukefromdc Yes, the function/option was present since version 0.52 (and the GNOME developers did tell other projects about it at the time) but in 0.56 the default was changed from true to false without any warning.

micheal65536 commented 5 years ago

I've added the version check macro as requested. I haven't tested if this builds with either newer or older versions of VTE.

sc0w commented 5 years ago

@micheal65536 thanks!