search

mate-desktop / mate-terminal

The MATE Terminal Emulator
http://www.mate-desktop.org
GNU General Public License v3.0
133 stars 73 forks source link

terminal-window: expand the content of the comment on about dialog #338

Closed rbuj closed 4 years ago

rbuj commented 4 years ago

Before

Screenshot at 2020-03-30 22-52-14

After

Screenshot at 2020-03-31 16-39-06

sc0w commented 4 years ago

I don't like the dot in the number version, the look is very weird

according to your concerns, why not add it to 1.24.0.?

and why not to MATE Terminal. ?

rbuj commented 4 years ago

@sc0w Generally, a full stop is not used at the end of a title, heading or subheading, as well as in lists or enumerations.

sc0w commented 4 years ago

@rbuj

Generally, a full stop is not used at the end of a title, heading or subheading, as well as in lists or enumerations.

Generally a full stop is not used un about dialogs, they aren't books.

rbuj commented 4 years ago

@selectiveduplicate some examples:

$ msgunfmt /usr/share/locale/en_GB/LC_MESSAGES/*.mo | grep -E "[0-9]+\.[0-9]+\."
"Indicates the version of <GPSInfoIFD>. The version is given as 2.0.0.0. This "
"Indicates the version of <GPSInfoIFD>. The version is given as 2.0.0.0. This "
"deprecated since GNOME 2.12."
"deprecated since GNOME 2.12."
"been deprecated since GNOME 2.12."
"been deprecated since GNOME 2.12."
"deprecated since GNOME 2.12."
"deprecated since GNOME 2.12."
"Window manager to try first. This key has been deprecated since GNOME 2.12."
"Window manager to try first. This key has been deprecated since GNOME 2.12."
"How far you have to move until the stroke input reaches 1.0. This value is "
"How far you have to move until the stroke input reaches 1.0. This value is "
"This defines how long the stroke input stays at 1.0. After that it will "
"This defines how long the stroke input stays at 1.0. After that it will "
msgid "Metadata won't be visible in GIMP older than version 2.10."
rbuj commented 4 years ago

@sc0w I'm not saying that the full stop should be used for all strings, only that it should be used for the comment. In this case, full stops are needed for ending the two sentences:

1st sencence: (It's) A terminal emulator for the MATE desktop.
2nd sencence: (It's) Using VTE 0.60.0.
selectiveduplicate commented 4 years ago

@rbuj I'd prefer to have the VTE version listed just under the mate-terminal version, as VTE 0.60.0, with no period. But in this way, I'm not sure; it looks weird to me. More reviewers would need to have a look; all the other applications would need changing too after this.

rbuj commented 4 years ago

I expanded the comment on about dialog

sc0w commented 4 years ago

Personally I prefer to see the dialog simplest, like before, without largest explanations, if we like, we have more info in the help

rbuj commented 4 years ago

@vkareh done

Screenshot at 2020-04-01 17-15-15

sc0w commented 4 years ago

I am still thinking it is redundant to mention twice "MATE Terminal" in the dialog

vkareh commented 4 years ago

I am still thinking it is redundant to mention twice "MATE Terminal" in the dialog

It's not mentioning it twice, "MATE Terminal" is the name of the software, and it happens to be a "terminal" part of the "MATE" desktop environment... I agree that it's a bit odd, sure, but it's still accurate, in my opinion.

raveit65 commented 4 years ago

For me this looks OK. Honestly, i don't care if there is a dot or not, or that mate-terminal is mentioned twice. I think the world has another problems. https://www.worldometers.info/coronavirus/

sc0w commented 4 years ago

"MATE Terminal is a terminal ..." very redundant text :)

anyway I have no problem if others like to merge it