mate-desktop / mate-terminal

The MATE Terminal Emulator
http://www.mate-desktop.org
GNU General Public License v3.0
134 stars 73 forks source link

terminal_profile_edit_dialog_page_scroll_event_cb is only used in profile-editor.c #361

Closed rbuj closed 4 years ago

rbuj commented 4 years ago

Based on:

tamplan commented 4 years ago

Well done, more the function is static! My C and my English are a rusty fear...

tamplan commented 4 years ago

You rename the function? I have understood the functions' name should be begins the same way, in this case terminal_ or here you are, of course, right profile_.

I saw a function like terminal_profile_editor_focus_widgetfor example, is there any rule about this? In case i make mistakes later...

rbuj commented 4 years ago

profile_editor_nb_scroll_event_cb is used only in profile-editor.c, it's different to terminal_profile_edit which is a global function.

doxy

tamplan commented 4 years ago

Ok, if a function is global (ie called more than once and no static), this name should begin with other like the filename? Private functions can be names like we want because they are private (with a correct name i presume)?

Good method, i note it.

What is the tool you use for this diagram?

I know every day i have more and more things to learn...

rbuj commented 4 years ago

What is the tool you use for this diagram?

doxygen

tamplan commented 4 years ago

What is the tool you use for this diagram?

doxygen

Ok, thanks you.