search

mate-desktop / mate-terminal

The MATE Terminal Emulator
http://www.mate-desktop.org
GNU General Public License v3.0
134 stars 73 forks source link

Add "Not found" message box to search dialog #405

Closed tochlab closed 2 years ago

tochlab commented 2 years ago

Sometimes it's useful to see nothing was found in the buffer.

raveit65 commented 2 years ago

Hmm, is this really needed? Now the user needs to click away another popup. If your search doesn't show you a match in terminal, why you want to see a confirmation for nothing? This shouldn't be the default behavior.

raveit65 commented 2 years ago

Sometimes it's useful to see nothing was found in the buffer.

Please describe exactly when this is useful. "sometimes" is meaningless.

tochlab commented 2 years ago

From user's point of view it's useful to know about any result of operation. As an example: when your buffer counts thousands of lines not always clear is search finished without result or it still in progress.

raveit65 commented 2 years ago

I am using an unlimited buffer since years and it is always clear if i have a search result or not. Well, i agree if you use an gsettings key to disable this weird setting as default. And ofcourse another team member should like this ;)

tochlab commented 2 years ago

Well, I think we all have different experience and habits. But if you take a look to browser/offices/ide you'll see that most of them informs users about "0 result found". Not sure message box is a good way to inform user but it's what I was able to do(and now happy to use :) ).

raveit65 commented 2 years ago

Simply add a setting in preferences with a gesetting key to disable/enable this feature. I suspect that a lot of users don't like an unneeded extra click with mouse or keyboard press.

tochlab commented 2 years ago

May be a better way to avoid unneeded clicks would be another notification? Something like red board around input field?