search

mate-desktop / mate-terminal

The MATE Terminal Emulator
http://www.mate-desktop.org
GNU General Public License v3.0
135 stars 73 forks source link

Fix implicit conversion changes signedness: 'gboolean' to 'guint' #408

Closed rbuj closed 2 years ago

rbuj commented 2 years ago 
git submodule init
git submodule update --recursive --remote
CFLAGS="-Wconversion -Wunused-macros -Wunused-parameter" CC=clang ./autogen.sh --prefix=/usr --enable-debug --enable-compile-warnings=maximum && make &> make.log
terminal-encoding.c:162:49: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
        encoding->valid = encoding->validity_checked = force_valid;
                                                     ~ ^~~~~~~~~~~
terminal-encoding.c:163:24: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
        encoding->is_custom = is_custom;
                            ~ ^~~~~~~~~
--
terminal-window.c:2728:29: warning: implicit conversion changes signedness: 'gboolean' (aka 'int') to 'guint' (aka 'unsigned int') [-Wsign-conversion]
    priv->menubar_visible = setting;
                          ~ ^~~~~~~
raveit65 commented 2 years ago

I can confirm that Pr fixes the warnings.

raveit65 commented 2 years ago

Just a rebase with master to fix hopefully debian build at travis.