search

mate-desktop / mate-terminal

The MATE Terminal Emulator
http://www.mate-desktop.org
GNU General Public License v3.0
135 stars 73 forks source link

[Feature Request] Set Title dialog: Accept input with Enter key #435

Closed Gydo194 closed 1 year ago

Gydo194 commented 1 year ago

Background to request

I often use custom window and tab titles to keep my terminals organized. When setting a tab title, the user has to click the 'OK' button on the 'Set Title' dialog. It feels like I can just hit enter to accept the dialog, but I have to click the button instead.

Expected behaviour

When changing the title of a window or tab, the 'Set Title' dialog should accept the user's input when the user presses enter.

Actual behaviour

The enter key is ignored, forcing the user to press the 'OK' button using the mouse.

Gydo194 commented 1 year ago

I'd like to work on this myself, as my first contribution to MATE.

lukefromdc commented 1 year ago

Go for it, we can always use more coders

allanlaal commented 1 year ago

isnt this fixed in 1.27 ?

cwendling commented 1 year ago

It is already fixed indeed, see #394, and #421 is also a duplicate of this.

No worries, but please try and check the issues (even closed), and test the development branch ;) This said, if it's still broken in the dev branch (e.g. the fix doesn't work anymore), that's another story -- and please mention it so we know it's a regression :)

Gydo194 commented 1 year ago

Oops, sorry for the duplicate. I completely missed those issues while searching. And it does indeed work after installing from source.. My bad.