search

mate-desktop / mate-terminal

The MATE Terminal Emulator
http://www.mate-desktop.org
GNU General Public License v3.0
135 stars 73 forks source link

Do not set DISPLAY, inherit it instead #437

Closed lukefromdc closed 12 months ago

lukefromdc commented 12 months ago

Otherwise x11-only apps in wayland can't connect to xwayland Fix https://github.com/mate-desktop/mate-terminal/issues/423

lukefromdc commented 12 months ago

Found to work by both https://github.com/llyyr and https://github.com/furryfixer

raveit65 commented 12 months ago

This make it possible to run miral-shell with shell-terminal-emulator=mate-terminal option in ~/.config/miral-shell.config. And a lot of more application are starting from mate-panel-menus. echo $DISPLAY is now empty in miral-shell, good?

lukefromdc commented 12 months ago

In x11 if I run envin terminal the output includes DISPLAY=:0 in wayfire it includes DISPLAY=:1 and so far I haven't had any problems

cwendling commented 12 months ago

Hum… I couldn't find the rationale for having the DISPLAY set manually (it predates the repository), but I would think there was one, wasn't it? A more conservative patch would have been moving the line inside the X11 code path.

Anyway, if everything's fine I'm OK with this, but it might be something to watch out for.