search

mate-desktop / mate-terminal

The MATE Terminal Emulator
http://www.mate-desktop.org
GNU General Public License v3.0
135 stars 73 forks source link

Tabs: only invoke naming dialog to doubleclick on tab header #446

Closed lukefromdc closed 9 months ago

lukefromdc commented 9 months ago

Prevent double-clicking on terminal contents while certain in-terminal apps such as htop are running from invoking the tab rename dialog meant to be triggered by double-clicking on the tab's header

lukefromdc commented 9 months ago

Fixes https://github.com/mate-desktop/mate-terminal/issues/444

lukefromdc commented 9 months ago

The problem I had was I was totally unable to find any way to distinguish between the little tab header at the top of the active tab, and the rest of the active tab/page. We cannot just borrow from XFCE unless they also forked gnome-terminal. This is not a feature I would ever use BTW, I was just trying to fix a bug in it. It does need to be either fixed or removed (the offending commit reverted).

I can try your proposed code tomorrow and see if it works, I need to go to bed right now.,

lukefromdc commented 9 months ago

Just change the code to @cwendling 's proposed fix that directly uses the tab allocation for this. Should be more robust as it does not depend on how any potential font, window scale, or theme might determine the height of the tab headers

lukefromdc commented 9 months ago

Well, three of us have tested this code, two of us have worked on it and nobody has had problems with it. This looks good to go, so will merge