search

mate-desktop / mate-themes

Official themes for the MATE desktop
https://mate-desktop.org
GNU Lesser General Public License v2.1
76 stars 45 forks source link

the highlighting doesn't work while I press the tab key #156

Closed sc0w closed 7 years ago

sc0w commented 7 years ago

with the tab key, I can't see the highlighting on a lot of buttons, checkboxes, list views, etc etc

The result: it is impossible to work with mate only with keyboard (without mouse)

( mate 1.16 "traditional ok" theme )

I have tested with monitor preferences, pluma preferences...

sc0w commented 7 years ago

sorry, I couldn't do the tests before

my tests:

green submarine

I think is difficult to see the focus on the attached buttons

greensub

green laguna

I think it doesn't need dashed lines on some situations, for example on "log out", or "shut down"

greenlaguna

Green submarine and blue submarine

the focus don't works successfully on mate control center

raveit65 commented 7 years ago

hmm, i released yesterday. @green-submarine I will see if i can use a better color for logout dialog. @greenlaguna I wanted to do a simple solution here with less work and not going into details like other themes. Well using outlines and a different button bg is double, but is this really bad? For me this is OK.

raveit65 commented 7 years ago

Submarine themes I see that box-shadow if a button have focus in mate-control-center. https://github.com/mate-desktop/mate-themes/blob/master/desktop-themes/Blue-Submarine/gtk-3.0/gtk-widgets.css#L1041 Which matches the style for other focused buttons in that theme.

raveit65 commented 7 years ago

Fix for linked dialog-action button in Green-Submarine https://github.com/mate-desktop/mate-themes/commit/de5f83e32375a853eecc6c4f691783af53d1afdf @sc0w Please test

sc0w commented 7 years ago

Fix for linked dialog-action button in Green-Submarine

ok, it looks better now

m-c-c on submarine themes:

I uploaded a video, for me appears the focus and immediately disappears, @raveit65 can you confirm this?

https://mega.nz/#!INpDBYpQ!bdZ3YVPOYd771YDRhhkN5snjcTH2BQ0cFpFQOSfl5so

more tests on submarine themes:

I can't see the focus with the "tab" key on the mate screensaver

raveit65 commented 7 years ago

m-c-c on submarine themes: I uploaded a video, for me appears the focus and immediately disappears, @raveit65 can you confirm this?

wtf, i can confirm the flashing borders in control-center with Submarine themes with released http://pub.mate-desktop.org/releases/themes/3.22/mate-themes-3.22.6.tar.xz But i don't see that here in f24 (gtk+-3.20) were i did all theme hacks. But i recall that i fixed this problem somewhere.....

more tests on submarine themes: I can't see the focus with the "tab" key on the mate screensaver

Opps, i forgot that submarine themes use a dark own style for lock-dialog.

sc0w commented 7 years ago

But i recall that i fixed this problem somewhere.....

I did a pull request with one possible solution: https://github.com/mate-desktop/mate-themes/pull/157

raveit65 commented 7 years ago

Ok, seems that only outlines are working with gtk+-3.22 for m-c-c button.flat. So i imitate the box-shadow style here. https://github.com/mate-desktop/mate-themes/commit/7410e19d49ecbddcd38bb991233dd6f12e50ac74

raveit65 commented 7 years ago

https://github.com/mate-desktop/mate-themes/commit/dd4fa97d4a335c58af1f0b90669b08e3e43073e6 and fix for lock-dialog. But this seems a bit useless as login button is always prefered by code. @sc0w Hope we have fix now all issues.

sc0w commented 7 years ago

ok, it works, and more tests:

I have tested m-c-c on all themes, on blackmate the focus appears and disappears:

https://mega.nz/#!0AwHlQCY!A3OUXnWyrFao0XMeFihtRcG8jzj6kJ45z2HSyPkgXNg

sc0w commented 7 years ago

green submarine

the focus doesn't work on this item:

caja_greensubmarine

blue submarine

the focus doesn't work on these items:

caja_bluesubmarine

black mate

the focus appears and disappears on these items, like m-c-c on my previous comment

caja_blackmate

and that's all, no more tests :)

lukefromdc commented 7 years ago

https://github.com/mate-desktop/mate-themes/commit/47eb6457c8423ffe5cbeff42510fed152e66b841 Fixes disappearing focus outlines on flat buttons in BlackMATE. Had to use outlines only and not borders or background images due to a GTK3.22 bug where the last-child button in some cases never finished rendering any background if focusses. The background would come up not at all or in some cases corrupted while animation showed an endless loop in GtkInspector and CPU use soared.

I also found an issue in mate-control-center: the buttons won't take focus and hover at the same time, so I had to accept that the keyboard focussed buttons would not show a change from being hovered with the mouse.

raveit65 commented 7 years ago

I also found an issue in mate-control-center: the buttons won't take focus and hover at the same time, so I had to accept that the keyboard focussed buttons would not show a change from being hovered with the mouse.

Yeah i noticed that too, button.flat:focus:hover is broken with 3.20 too. Not sure if this is a limitation with flat buttons by gtk+ or a m-c-c issue. With 3.20 it was possible to write a box-shadow on focus state. With 3.22 only outlines are working.

raveit65 commented 7 years ago

https://github.com/mate-desktop/mate-themes/commit/3f01fa91885ca5293f80665dfad415a48efc6042 fixes for caja-pathbar buttons with Submarine themes.

@sc0w Can you you give me one more feedback please? Is everything alright? I want to avoid another useless release for 3.20/22 ;-)

sc0w commented 7 years ago

on my latest tests:

the focus doesn't work on blue submarine here:

cajabluesubmarinefocus

sc0w commented 7 years ago

weird, some tray icons with dashed outlines on all themes

images from TOK:

111

the stop button of recordmydesktop

112

and the amule tray icon

raveit65 commented 7 years ago

on my latest tests: the focus doesn't work on blue submarine here: cajabluesubmarinefocus

Here the button.toggle.text-button.image-button:checked:focus have a blue box-shadow on top and bottom. Problem is that button:checked https://github.com/mate-desktop/mate-themes/blob/dev-keyboard-world/desktop-themes/Blue-Submarine/gtk-3.0/gtk-widgets.css#L1022 use nearly the same styling than the focus version from here https://github.com/mate-desktop/mate-themes/blob/dev-keyboard-world/desktop-themes/Blue-Submarine/gtk-3.0/mate-applications.css#L208 This is what gtk3-inspector told me, and it is the correct usage.

weird, some tray icons with dashed outlines on all themes images from TOK: 111 the stop button of recordmydesktop 112 and the amule tray icon

I guess those applications use gtk+-2 and we see the ' focus-line' and not the 'outline' style element

sc0w commented 7 years ago

amule uses wxwidgets 3, the other, I am not sure

well, I finished all the tests :)

sc0w commented 7 years ago

ups, I noticed dashed lines on the delete dialog of engrampa, on left click, on all themes

deletengrampa

lukefromdc commented 7 years ago

Those are radio buttons. The outline can be removed, at the expense that detecting focus becomes a bit more difficult on other radio buttons. In this case, the difference is the default radio button comes up focussed by default. BTW, checking a radio button will always focus it, and a radio button cannot be focussed without also making it the checked button. Checked but not focussed exists only when focus is not on any of the radio buttons but is elsewhere.

in UbuntuStudio_Legacy I used a "glow" for a normal checked radio button and a "double-glow" effect for both checked and focussed for this very reason. This would be hard to to in BlackMATE because without using colors it would get too subtle to easily see

raveit65 commented 7 years ago

This is correct, all themes use dashed outlines for check and radio buttons, and treeviews. ie. https://github.com/mate-desktop/mate-themes/blob/master/desktop-themes/BlueMenta/gtk-3.0/gtk-widgets.css#L16 Which is the default setting in gtk-widget.css. Later i override this settings for buttons in gtk-widget.css https://github.com/mate-desktop/mate-themes/blob/master/desktop-themes/BlueMenta/gtk-3.0/gtk-widgets.css#L213 https://github.com/mate-desktop/mate-themes/blob/master/desktop-themes/BlueMenta/gtk-3.0/gtk-widgets.css#L2407 https://github.com/mate-desktop/mate-themes/blob/master/desktop-themes/BlueMenta/gtk-3.0/gtk-widgets.css#L3395 https://github.com/mate-desktop/mate-themes/blob/master/desktop-themes/BlueMenta/gtk-3.0/gtk-widgets.css#L3581 In other themes it is the same but a bit simpler, except GreenLaguna which use dashed outlines everywhere.