search

mate-desktop / mate-themes

Official themes for the MATE desktop
https://mate-desktop.org
GNU Lesser General Public License v2.1
75 stars 45 forks source link

Fixed URL colors for Firefox search suggestions #167

Closed SistemaKrasho closed 7 years ago

SistemaKrasho commented 7 years ago

By default, FF uses #0000EE for the URLs (and separator) for the search suggestions and it looks bad, so I changed it to #2EB8E6 (same as GtkWidget::link-color).

lukefromdc commented 7 years ago

All of these require user action, but firefox has become such a nightmare to theme I don't see another way until upstream FF devs fix their GTK 3.20/22 mess. They now do support css nodes but still have a LOT of theming issues. I had to use a userChrome.css file to stop white on white text in the history popup on my theme-and found it using the theme default colors with absolutely no theming element, not even * able to override it from the GTK theme.

raveit65 commented 7 years ago

@lukefromdc Do you agree with the PR? And is this good for all branches? I am just preparing new releases.......

lukefromdc commented 7 years ago

It gives the uses a way to fix the problem, I have no disagreement with that, just don't see any better way around this given the mess firefox devs have made out of theming. Go for it.

SistemaKrasho commented 7 years ago

@lukefromdc I've been looking in FF source code for a while now, more specifically the part where it implements GTK+ colors as constants in CSS. [see here] I'll look into fixing this at once, but first I'll have to actually get FF to build (I actually tried to, but it was taking too long then I gave up 😄) and then find a way to debug it.

Meanwhile, I think this here is a fair temporary fix and it can be improved even more. It'd be even better to ship BlackMATE with a proper FF skin aimed at fixing these color issues.

lukefromdc commented 7 years ago

I won't be as easily able to test these for the simple reason that my own theme also requires a userChrome.css file of its own with FF 51 and later. Possibly the file could be shipped intact in each theme (ignored by GTK) simply so users could drag and drop it to their firefox profile, and referred to in the README?

sc0w commented 7 years ago

This PR was merged in https://github.com/mate-desktop/mate-themes/commit/c29dd5ff5e003bf478118d10c04d6d32342516fb

I think it can be closed