Closed ghost closed 7 years ago
The handles marks the right click area and in other themes i replaced them with an image.
1) If we remove it, the user can't see differences between icon launchers and sys tray icons, and we need it to know where is it, to handle it (holding left click to move, or right click with more options)
2) I prefer the currently color
so, I disagree with this PR
That's fair. Two points though.
1) With regards to the handles, could they not at least be reduced from 4 vertical lines down to 2? The 4 lines seem a bit excessive to me.
2) Agree to disagree on the colours but can we not have consistency? GTK+ 2 applications still use white for both TraditionalGreen and TraditionalOk and TraditionalGreen GTK+ 3 is also still white. Why is TraditionalOk GTK+ 3 the odd one out here? Is this intentional?
What about a very subtle, barely visible handle that's there if you look for it, gives a place to drag the applet from, but is not visually obvious? That's similar to what I did in my own theme except I left it a little more visible as I just didn't want it at my normal grey background color on a black panel.
That's a good idea, thanks! I had a look a what was done in BlackMate and Menta and I'd be happy if the traditional themes used those handles personally. I've updated my PR in that regard and removed the menu colour changes.
I have tested your new proposal, and I see nothing:
That's odd. You should get the following: I did rebase the repo to remove the other commits, are you certain you have master?
@lukefromdc @raveit65 it works for you?
Yes, i copied the image to /usr/share/themes/TraditionalOk/gtk-3.0/img/ by hand and added the settings to mate-application.css. Of course we need to add the new image to MakeFile otherwise it won't installed.
I'm so sorry! I forgot to do that. For convenience sake, I was just symlinking TraditionalOk & TraditionalGreen in ${HOME}/.themes to test changes.
now it works
squashed and merged in https://github.com/mate-desktop/mate-themes/commit/31fde6135ccffef75d05b19d931fceb08abacc40
thanks
I think with this colors the look is better:
https://github.com/sc0w/mate-themes/commit/ce9f58386cce33b80192d3e8e07cde7bffb4afbd
up: no changes middle: use same color than @notebook_active_tab_strip_gradient_a down: use same color than @notebook_active_tab_strip_gradient_b
TOK
TG
@charlesbos what do you think? do you like it?
Thanks for merging. Yes, the colours look good! I like that idea.
1) Remove handles from the systray applet and the show desktop applet in both Traditional themes. They don't really add anything and, in my opinion, make the panel look more messy. See the vertical lines just to the left of the bluetooth icon in the screenshot:
2) There is inconsistency in the menu colors used for TraditionalGreen and TraditionalOk. TraditionalOk GTK+ 2 and TraditionalGreen GTK+ 2 & 3 use the base color which is white whilst TraditionalOk GTK+ 3 uses the background color which is grey. To bring TraditionalOk in line with everything else I changed the menu color to the base color. Aside from consistency, I prefer the white menus to the grey ones - I think they stand out more.