mate-desktop / mate-themes

Official themes for the MATE desktop
https://mate-desktop.org
GNU Lesser General Public License v2.1
75 stars 45 forks source link

[gtk3] [all themes] when dragging file/folder in caja, a black border is added inside pane #194

Closed kerreidru closed 7 years ago

kerreidru commented 7 years ago

I'm not sure if this is a theme issue or a caja issue? this started when caja switched to gtk3 ...

Here's what caja looks like before you drag a file/folder: before

Here's what caja looks like once you start to drag a file/folder (notice black border added inside pane): during-drag

this didn't occur in gtk2 version of caja.

MATE general version

1.18

Package version

mate-themes 3.22.13

Linux Distribution

Fedora

raveit65 commented 7 years ago

With https://github.com/mate-desktop/caja/pull/843 we use what is setup in gtk themes for the dnd style class. Ie. BlueMenta https://github.com/mate-desktop/mate-themes/blob/master/desktop-themes/BlueMenta/gtk-3.0/gtk-widgets.css#L225

.dnd {
    border-width: 1px;
    border-style: solid;
    border-color: @theme_selected_bg_color;
    border-radius: 0;
}

caja-dnd

kerreidru commented 7 years ago

looks a lot better!

raveit65 commented 7 years ago

Btw. Do you think we need a setting in themes here? Or is showing the drag state in caja view the most-wanted-useless-gtk3-setting ever? :-)

lukefromdc commented 7 years ago

As far as I am concerned, keeping the frame off the view is enough. Doing this for the theme as a whole and not just for Caja also fixes the same issue in Nemo and in Nautilus, where the same themes that draw the frame with Caja PR https://github.com/mate-desktop/caja/pull/843 also draw it in Nemo, and where it is not drawn by the other themes.

raveit65 commented 7 years ago

Fix will be include in next 1.18.x release, ....or maybe a bit quicker with a patch in fedora :-)