Fix more HighContrast themes visibility with metacity

[sthibaul]

This completes cf0a970f26d3 ("Fix HighContrast themes visibility with metacity").

When maximized windows are rendered with metacity (e.g. with metacity-theme-viewer), the back background parts of HighContrast and HighContrastInverse actually show up transparent. This is because the maximized_unfocused and maximized_focused styles do not use the proper focus draw_ops like normal_focused and normal_unfocused.

[monsta]

@alexarnaud: maybe you'd like to test this too, it's a follow-up to https://github.com/mate-desktop/mate-themes/pull/212.

[raveit65]

@monsta First, the previous PR needs corrected, HighContrast theme displays black as thumbnail in mate-appearance-properties. Maybe you need to delete thumbnail cache to see that.

[monsta]

Ok, I didn't know. I have normal thumbnail there. But I think that Debian packaging includes icon cache updating...

[monsta]

Sorry, I misunderstood. Now I removed all cached thumbnails, and I see the newly created black thumbnail.

[alexarnaud]

Le 28/04/2018 à 14:19, monsta a écrit :

@alexarnaud https://github.com/alexarnaud: maybe you'd like to test this too, it's a follow-up to #212 https://github.com/mate-desktop/mate-themes/pull/212.

I'm already using the Samuel's patch on my machine and I can confirm that it fixes the issue.

Best regards, Alex.

[raveit65]

Does this PR needs updating after last commit?

[sthibaul]

No, they are completely independent actually.

[raveit65]

ok, a rebase against master i can do for myself

[raveit65]

rebased and merged 595d9a6c8cf71f2002bb6c3ec27ad95263e6a871 Thanks

[raveit65]

weird, gradient looks complete different with metacity and marco. With metacity WM the purple gradient for forground windows is missing. And there is a gradient for unfocused windows which i don't see with marco WM. Would be nice to have same results with all WMs. Edit: i meant HCI theme

[raveit65]

Any way, i have no idea if this is cause by this PR or it was there before. Mostly i use marco WM with other themes.

[sthibaul]

Mmm, I'm not getting any such difference between marco and metacity as run by compiz.

[alexarnaud]

On my test, the result is correct on Marco.

Best regards, Alex.

[alexarnaud]

I've also tested on Compiz, it's OK. On Metacity I don't see the buttons to maximize and minimize but I don't understand why. Maybe @muktupavels could be aware of what's happen. Maybe what I observe is the correct behavior on Metacity.

Best regards, Alex.

[sthibaul]

Well, with pure metacity I am getting an entirely different aspect: which looks to me like it's a completely different set of themes which is getting used here (e.g. round corners, completely different close button), thus not related with mate-themes.

[muktupavels]

Metacity can use "old" metacity themes and also gtk+ themes just like mutter... Here is how things has changed in metacity related to theme settings: https://www.patreon.com/posts/12126230

What does gsettings get org.gnome.desktop.wm.preferences button-layout show? Default gnome button-layout has only appmenu:close if I remember correctly...

[sthibaul]

It shows appmenu:close only indeed.

[muktupavels]

gsettings set org.gnome.desktop.wm.preferences button-layout 'appmenu:minimize,maximize,close'

[raveit65]

For getting the normal windows menu in MATE session

[rave@mother ~]$ gsettings get org.gnome.desktop.wm.preferences button-layout
'menu:minimize,maximize,close'

[raveit65]

Ok, i found the weirdness. HCI from master with marco WM and mate-appearance-properties as focused window. (purple decoration)

Now i switched with fusion-icon to metacity WM but i didn't closed mate-appearance-properties (focused window).

But after i closed mate-appearance-properties and start it again, metacity shows me the HCI theme correct. I guess this happens because mate-appearance-properties support of theme switching with metacity isn't perfect.

Anyway i don't think that most users switching the WMs daily, so all is fine. @sthibaul Good work and sorry for that noise.