search

mate-desktop / mate-themes

Official themes for the MATE desktop
https://mate-desktop.org
GNU Lesser General Public License v2.1
76 stars 45 forks source link

all themes: xrandr-applet menu styling #225

Closed lukefromdc closed 6 years ago

lukefromdc commented 6 years ago

Support new xrandr applet popup theming. In most themes remove the monitor label background

raveit65 commented 6 years ago

@lukefromdc @sc0w @monsta Dear theme maintainers if you like to change something in your themes......go ahead.

monsta commented 6 years ago

Hmm... the commented parts look like they would affect other disabled labels and possibly other widgets too?

lukefromdc commented 6 years ago

Normally things like 


 label,
 label:disabled {
     background-color: transparent;
 }

don't seem to be needed anymore, with at least GTK 3.22 apparently defaulting to this. I removed it last week from my UbuntuStudio_Legacy theme and have yet to notice any side effects from it in daily use.

raveit65 commented 6 years ago

I just updated Menta themes and did a forced-push, now they looks really bad.....

@monsta

Hmm... the commented parts look like they would affect other disabled labels and possibly other widgets too?

No, i posted it already in another post related to this changes Eg. https://github.com/mate-desktop/mate-themes/blob/master/desktop-themes/BlueMenta/gtk-3.0/gtk-widgets.css#L95

image,
image:disabled,
label,
label:disabled,
box,
box:disabled,
grid,
grid:disabled {
    background-color: transparent;
}

Code blocks like this are remnants from < gtk+-3.20 css syntax. There is no reason to set a transparent color for a widget if nothing else before in css sets a color here. Also, using wildcards like this is a bad behaviour, because you never know which widgets do you match. https://github.com/mate-desktop/mate-themes/blob/master/desktop-themes/BlueMenta/gtk-3.0/gtk-widgets.css#L50 In Submarine theme i have removed such wildcards a while ago. This is a TODO for other themes.

monsta commented 6 years ago

Ok, so I get different results with various themes (and m-s-d built from git master).

Adwaita (which surely doesn't override anything): virtualbox_debian testing_23_05_2018_13_30_26

BlackMATE: virtualbox_debian testing_23_05_2018_13_30_41

Menta: virtualbox_debian testing_23_05_2018_13_31_00

monsta commented 6 years ago

I guess this needs some corrections either here or in m-s-d.

raveit65 commented 6 years ago

You did not applied https://github.com/mate-desktop/mate-settings-daemon/pull/224 Than adwaita use black font-color. BlackMate and Menta in your screenshots reflects theme settings from this PR.

monsta commented 6 years ago

Yes, I tested git master so far, will try https://github.com/mate-desktop/mate-settings-daemon/pull/224 too.

monsta commented 6 years ago

Ok, Adwaita has black text color now.

raveit65 commented 6 years ago

Menta themes are updated for https://github.com/mate-desktop/mate-settings-daemon/pull/226