search

mate-desktop / mate-themes

Official themes for the MATE desktop
https://mate-desktop.org
GNU Lesser General Public License v2.1
75 stars 45 forks source link

GNOME bringing out GTK 3.24, supposed to be backward compatable, OK so far #227

Open lukefromdc opened 6 years ago

lukefromdc commented 6 years ago

Expected behaviour

GNOME had announced GTK 3.22 would be the last GTK3 version

Actual behaviour

GNOME working on GTK 3.24 branch and has just release 3.23.1 Supposed to be backwards compatable and seems to be at the moment. This is because some GTK users are asking for new features that can't be backported to 3.22 and GTK4 (whose GSK work would break libreoffice and firefox) is taking a very long time https://blog.gtk.org/2018/06/23/a-gtk-3-update/ https://www.phoronix.com/scan.php?page=news_item&px=GTK-3.24-Coming-This-Fall

Steps to reproduce the behaviour

git clone GTK+ and checkout the 3.24 branch, build, install, and restart session. For now, everything works OK (I checked all themes) but this will have to be watched closely for any problems

MATE general version

1.21

Package version

Locally built gtk3.23 being tested here, I will keep an eye on this but note that bugs I get on non-theme matters may differ from gtk 3.22.30, which is said to be the last GTK 3.22 release now

Linux Distribution

Debian Unstable

Link to downstream report of your Distribution

None, I use locally compiled GTK+ and just want to give the rest of the team a heads-up on this

--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/60068187-gnome-bringing-out-gtk-3-24-supposed-to-be-backward-compatable-ok-so-far?utm_campaign=plugin&utm_content=tracker%2F293056&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F293056&utm_medium=issues&utm_source=github).
raveit65 commented 6 years ago

So, we should re-organized repo structure like you did it for your own theme? I mean different folders for gtk+ versions with one base folder. This is one thing which is on my List, but i don't know exactly how this should work.

lukefromdc commented 6 years ago

They are claiming no change in theming, and my theme works fine so far. We will be abke to bump versions over it I suppose

On 06/25/2018 at 3:25 AM, "raveit65" notifications@github.com wrote:

So, we should re-organized repo structure like you did it for your own theme? I mean different folders for gtk+ versions with one base folder. This is one thing which is on my List, but i don't know exactly how this should work.

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/mate-desktop/mate- themes/issues/227#issuecomment-399857322

raveit65 commented 6 years ago

What i really avoid is to use different branches for different gtk+ versions again. In your theme you use this structure.

[rave@mother gtk-theme-ubuntustudio-legacy]$ ls -l UbuntuStudio_Legacy/
insgesamt 36
drwxrwxr-x 4 rave rave 4096 29. Apr 09:23 gtk-2.0
drwxrwxr-x 2 rave rave 4096 29. Apr 09:23 gtk-2.0-key
drwxrwxr-x 4 rave rave 4096 29. Apr 09:23 gtk-3.0
drwxrwxr-x 4 rave rave 4096 29. Apr 09:23 gtk-3.18
drwxrwxr-x 5 rave rave 4096 29. Apr 09:23 gtk-3.20
drwxrwxr-x 5 rave rave 4096 29. Apr 09:23 gtk-4.0
drwxrwxr-x 2 rave rave 4096 29. Apr 09:23 metacity-1

What gtk+ version is supported with the gtk-3.0 folder? And are the other 3.18/20 folders complete theme versions or does they only include the diff to 3.0? How do you handle icons? Are icons double in every 3.0/4.0 folder?

In the end is using one branch less work as we don't need to cherry-pick commits to each branches.

lukefromdc commented 6 years ago

What I have found is that GK uses the newest versioned folder that does not exceed the current GTK version. I've had no issues at all.

On 6/28/2018 at 2:10 AM, "raveit65" notifications@github.com wrote:

What i really avoid is to use different branches for different gtk+ versions again. In your theme you use this structure.

[rave@mother gtk-theme-ubuntustudio-legacy]$ ls -l 
UbuntuStudio_Legacy/
insgesamt 36
drwxrwxr-x 4 rave rave 4096 29. Apr 09:23 gtk-2.0
drwxrwxr-x 2 rave rave 4096 29. Apr 09:23 gtk-2.0-key
drwxrwxr-x 4 rave rave 4096 29. Apr 09:23 gtk-3.0
drwxrwxr-x 4 rave rave 4096 29. Apr 09:23 gtk-3.18
drwxrwxr-x 5 rave rave 4096 29. Apr 09:23 gtk-3.20
drwxrwxr-x 5 rave rave 4096 29. Apr 09:23 gtk-4.0
drwxrwxr-x 2 rave rave 4096 29. Apr 09:23 metacity-1

What gtk+ version is supported with the gtk-3.0 folder? And are the other 3.18/20 folders complete theme versions or does they only include the diff to 3.0? How do you handle icons? Are icons double in every 3.0/4.0 folder?

In the end is using one branch less work as we don't need to cherry-pick commits to other branches.

-- You are receiving this because you authored the thread. Reply to this email directly or view it on GitHub: https://github.com/mate-desktop/mate- themes/issues/227#issuecomment-400922247