mate-desktop / mate-themes

Official themes for the MATE desktop
https://mate-desktop.org
GNU Lesser General Public License v2.1
75 stars 45 forks source link

Volume applet (keyboard control) does not respect gtk theme #229

Closed mesouug closed 4 years ago

mesouug commented 6 years ago

Expected behaviour

Volume applet (keyboard control) should have background according to gtk theme.

Actual behaviour

Volume applet (keyboard control) does not respect gtk theme. Appears as just black box.

Steps to reproduce the behaviour

Select window manager: Marco (no compositor)

MATE general version

1.20.1

Package version

not sure

Linux Distribution

Ubuntu 18.04

Link to downstream report of your Distribution

screenshot at 2018-07-08 11-43-54 screenshot at 2018-07-08 11-43-39

raveit65 commented 6 years ago

I don't see any link to a downstream report :) Btw. this code is from another package not related to mate-media At least this isn't a bug. How should transparency work without a compositor?

mesouug commented 6 years ago

It should not be transparent at all. It should look like ordinary window and respect gtk theme. In which repo I should create issue?

lukefromdc commented 6 years ago

The repository involved is mate-settings-daemon, the file involved is plugins/common/msd-osd-window.c , and the window is rendered when not composted by this code, which is not themable by GTK:

        gtk_render_frame (context,
                          cr,
                          0,
                          0,
                          width,
                          height);

To follow the GTK theme would require a significant rewrite of this part an OSD that when first added to GNOME 2 worked only with compositing.