search

mate-desktop / mate-themes

Official themes for the MATE desktop
https://mate-desktop.org
GNU Lesser General Public License v2.1
76 stars 45 forks source link

Fix hard to resize windows in BlackMATE #251

Closed lukefromdc closed 5 years ago

lukefromdc commented 5 years ago

With recent changes in (probably) GTK3, windows became hard to resize in BlackMATE due to 1px border width requiring exact alignment of the cursor in metacity-theme-3.xml . https://github.com/mate-desktop/mate-themes/issues/249 Change left/right borders to 5px and bottom border to 6px (the latter already specified for metacity-theme-1.xml and metacity-theme-2.xml ).

raveit65 commented 5 years ago

You know that left/right_width doesn't increase the borders of the titlebar itself? This will only change border-size of the other parts from a window under the titlebar. After invisible-borders is merged i'd like to ship a second index.theme file for each theme with a different metacity-theme file, to fix the problem in non compositor case. In result the users can select 2 themes. Eg. BlackMate and BlackMate-non-compositor, BlueMenta and BlueMenta-non-compositor, etc. Because personal i don't think that such a huge border looks nice for a theme. And only a few users don't use compositor.

raveit65 commented 5 years ago

This is my plan for Menta and Submarine themes. https://github.com/mate-desktop/mate-themes/pull/252 We can do the same for other themes too.

lukefromdc commented 5 years ago

So merge this, than wait for a PR giving the second option for a metacity theme with no borders for compositing with the upcoming Marco(and compiz) work?

lukefromdc commented 5 years ago

I can see that very subtle undersize titlebar on close examination: it's not easy to see here. Will have to deal with that tomorrow as I am out of time now.

raveit65 commented 5 years ago

So merge this, than wait for a PR giving the second option for a metacity theme with no borders for compositing with the upcoming Marco(and compiz) work?

Like you want to do. But i not sure to make a new mate-themes-release without changes for marco PR.

lukefromdc commented 5 years ago

On close examination (at least with metacity theme version 3 in use) I cannot find any "step" at the junction of the titlebar to the rest of the window, only a very, very subtle angle. Making a couple other changes in the metacity theme version 3 file had no effect on that-and it is also present in current master, alongside the very, very touchy 1px resize alignment requirement. Thus I see no new issue with this, will merge

raveit65 commented 5 years ago

I cherry-picked the commit to gtk3.22 branch for you. Keep in mind that i create tarballs from gtk3.22 branch and not from master.

lukefromdc commented 5 years ago

Thanks, I forgot about that with all the other stuff I have had to deal with (outside of MATE) lately.

On 5/29/2019 at 3:44 AM, "raveit65" notifications@github.com wrote:

I cherry-picked the commit to gtk3.22 branch for you. Keep in mind that i create tarballs from gtk3.22 branch and not from master.

-- You are receiving this because you modified the open/close state. Reply to this email directly or view it on GitHub: https://github.com/mate-desktop/mate-themes/pull/251#issuecomment- 496824248